BottomNavigationBar traversal order unintuitive #14375

Activity

1. goderbauer

   added

   a: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)

   on Jan 31, 2018
2. goderbauer

   added

   from: a11y reviewReported by an accessibility review teamReported by an accessibility review team

   on Mar 5, 2018
3. goderbauer commented on Mar 6, 2018

   

   goderbauer

   on Mar 6, 2018

   MemberAuthor

   More actions

   @yjbanov This is a good example where our traversal order is way off on iOS:

   import 'package:flutter/material.dart';
   
   void main() => runApp(new MyApp());
   
   class MyApp extends StatelessWidget {
     // This widget is the root of your application.
     @override
     Widget build(BuildContext context) {
       return new MaterialApp(
         title: 'Flutter Demo',
         theme: new ThemeData(
           primarySwatch: Colors.blue,
         ),
         home: new BottomNavDemo(),
       );
     }
   }
   
   class BottomNavDemo extends StatefulWidget {
     @override
     State<BottomNavDemo> createState() {
       return new _BottomNavDemoState();
     }
   }
   
   class _BottomNavDemoState extends State<BottomNavDemo> {
     // The current page we're looking at.
     int currentPageIndex = 0;
   
     // How many pages from `pageTitles` we show.
     int shownPages = 5;
   
     List<String> pageTitles = <String>['Foo', 'Bar', 'Baz', 'Doge', 'Pupper'];
   
     // The minimum number of pages we'll show.
     static const minPages = 3;
     static const padding = const Padding(
       padding: const EdgeInsets.symmetric(vertical: 8.0),
     );
   
     @override
     Widget build(BuildContext context) {
       return new Scaffold(
         appBar: new AppBar(
           title: new Text(
             'Bottom Navigation',
             style: Theme.of(context).textTheme.title,
           ),
           elevation: 0.0,
           backgroundColor: Colors.white,
         ),
         bottomNavigationBar: new BottomNavigationBar(
           items: _buildItems(context),
           type: BottomNavigationBarType.fixed,
           currentIndex: currentPageIndex,
           onTap: _selectPage,
         ),
         body: new Center(
           child: new Text('Page ${pageTitles[currentPageIndex]}'),
         ),
       );
     }
   
     List<BottomNavigationBarItem> _buildItems(BuildContext context) {
       return pageTitles.take(shownPages).map((pageTitle) {
         return new BottomNavigationBarItem(
           icon: new Icon(Icons.star),
           title: new Text(pageTitle),
           backgroundColor: Colors.white,
         );
       }).toList();
     }
   
     void _selectPage(int value) {
       setState(() {
         currentPageIndex = value;
       });
     }
   }
4. goderbauer commented on Mar 6, 2018

   

   goderbauer

   on Mar 6, 2018

   MemberAuthor

   More actions

   @gspencergoog The out-of-the-box computed traversal order for Android also fails on this one: If the middle tab of 5 (number 3) is selected, the computed order is Tab 1, 2, 4, 5, 3. This looks like something that should be out-of-the-box correct without requiring fine tuning of traversal order.
5. goderbauer

   added this to the 3: Current Milestone milestone on Mar 16, 2018
6. goderbauer

   changed the title [-]BottomNavigationBar is not accessible[/-] [+]BottomNavigationBar traversal order unintuitive[/+] on Apr 3, 2018
7. yjbanov

   self-assigned this

   on Apr 4, 2018
8. Hixie

   modified the milestones: 3: Current Milestone, 4: Next milestoneThis milestone has been deleted on Apr 11, 2018
9. yjbanov

   closed this as completedin #16253on Apr 23, 2018
10. github-actions commented on Aug 16, 2021

    

    github-actionsbot

    on Aug 16, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
11. github-actions

    locked as resolved and limited conversation to collaborators on Aug 16, 2021