Repository navigation
[two_dimensional_scrollables] Merged cells is rendered in wrong position when pinned and scrolled #144100
Description
Steps to reproduce
- Add two_dimensional_scrollables 0.1.1 package
- Add a TableView.builder() with pinned rows (pinnedRowCount: 1) and columns (pinnedColumnCount: 1).
- Add merged cell (rowMergeStart: 2, rowMergeSpan: 2, columnMergeStart: 2, columnMergeSpan:2)
Expected results
The merged cell is shown in correct position (pos = (2,2), size = (2,2)).
Actual results
The merged cell is shown at pos = (1, 1) and size = (2, 2).
if TableView.builder does not have pinnedRowCount and pinnedColumnCount setting, it is shown in expected position.
Code sample
Code sample
import 'package:flutter/material.dart';
import 'package:two_dimensional_scrollables/two_dimensional_scrollables.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
useMaterial3: true,
),
home: const HomePage());
}
}
class HomePage extends StatefulWidget {
const HomePage({super.key});
@override
State<HomePage> createState() => _HomePageState();
}
class _HomePageState extends State<HomePage> {
final ScrollController _verticalController = ScrollController();
final ScrollController _horizontalController = ScrollController();
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: const Text('Home Page'),
),
body: TableView.builder(
columnCount: 10,
rowCount: 10,
columnBuilder: _buildColumnSpan,
rowBuilder: _buildRowSpan,
cellBuilder: _buildCell,
pinnedRowCount: 1,
pinnedColumnCount: 1,
verticalDetails:
ScrollableDetails.vertical(controller: _verticalController),
horizontalDetails:
ScrollableDetails.horizontal(controller: _horizontalController),
),
);
}
TableSpan _buildColumnSpan(int index) {
return const TableSpan(
extent: FixedTableSpanExtent(100),
foregroundDecoration: TableSpanDecoration(
border: TableSpanBorder(
trailing: BorderSide(
color: Colors.black,
width: 2,
style: BorderStyle.solid,
),
),
),
);
}
TableSpan _buildRowSpan(int index) {
return TableSpan(
extent: const FixedTableSpanExtent(100),
backgroundDecoration: TableSpanDecoration(
color: index.isEven ? Colors.blueAccent[100] : Colors.white,
),
);
}
TableViewCell _buildCell(BuildContext context, TableVicinity vicinity) {
if (vicinity.row == 2 && vicinity.column == 2) {
return TableViewCell(
rowMergeStart: vicinity.row,
rowMergeSpan: 2,
columnMergeStart: vicinity.column,
columnMergeSpan: 2,
child: Center(
child: Text('## Tile c: ${vicinity.column}, r: ${vicinity.row}'),
),
);
}
return TableViewCell(
child: Center(
child: Text('Tile c: ${vicinity.column}, r: ${vicinity.row}'),
),
);
}
}
Screenshots or Video
Screenshots / Video demonstration
[Upload media here]
Logs
Logs
[Paste your logs here]Flutter Doctor output
Doctor output
[Paste your output here]
❯ flutter doctor -v
[✓] Flutter (Channel stable, 3.19.1, on macOS 14.2.1 23C71 darwin-arm64, locale ja-JP)
• Flutter version 3.19.1 on channel stable at /Users/ken.masumitsu/.asdf/installs/flutter/3.19.1-stable
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision abb292a07e (5 days ago), 2024-02-20 14:35:05 -0800
• Engine revision 04817c99c9
• Dart version 3.3.0
• DevTools version 2.31.1
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/ken.masumitsu/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
• All Android licenses accepted.
[!] Xcode - develop for iOS and macOS (Xcode 15.2)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15C500b
✗ Unable to get list of installed Simulator runtimes.
! CocoaPods 1.12.1 out of date (1.13.0 is recommended).
CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
Without CocoaPods, plugins will not work on iOS or macOS.
For more info, see https://flutter.dev/platform-plugins
To upgrade see https://guides.cocoapods.org/using/getting-started.html#updating-cocoapods for instructions.
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2023.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
[✓] VS Code (version 1.86.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.82.0
[✓] Connected device (3 available)
• sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64 • Android 14 (API 34) (emulator)
• macOS (desktop) • macos • darwin-arm64 • macOS 14.2.1 23C71 darwin-arm64
• Chrome (web) • chrome • web-javascript • Google Chrome 121.0.6167.184
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 1 category.Metadata
Metadata
Assignees
Labels
Important issues not at the top of the work listViewports, list views, slivers, etc.Found to occur in 3.19Found to occur in 3.20flutter/packages/flutter repository. See also f: labels.The issue has been confirmed reproducible and is ready to work onIssues pertaining to the two_dimensional_scrollables packageOwned by Framework teamTriaged by Framework teamA fix is in flight
Activity
kenmasumitsu commentedon Feb 26, 2024
If I comment out pinnedRowCount and pinnedColumnCount, it works expectedly.
dam-ease commentedon Feb 26, 2024
Thanks for filing this @kenmasumitsu.
I can reproduce this on the latest
masterandstablechannels. WhenpinnedRowCountandpinnedColumnCountare set to 0, it works as intended.This might be related to #143526 but this issue reproduces on the latest version of the package which has this fix.
stable, master flutter doctor -v
[two_dimensional_scrollables] Fix another combo of pinned/unpinned me…
github-actions commentedon Mar 21, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.[two_dimensional_scrollables] Fix another combo of pinned/unpinned me…
[two_dimensional_scrollables] Fix another combo of pinned/unpinned me…