Expose onTapOutside from SearchBar's TextField #145096

Activity

1. danagbemava-nc

   added

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   c: new featureNothing broken; request for a new capabilityNothing broken; request for a new capability

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   p: material_uimaterial_ui package in flutter/packagesmaterial_ui package in flutter/packages

   c: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutter

   team-designOwned by Design Languages teamOwned by Design Languages team

   and removed

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   on Mar 14, 2024
2. Sahil-kachhap commented on Mar 15, 2024

   

   Sahil-kachhap

   on Mar 15, 2024

   Contributor

   More actions

   Use case

   All the TextFields in my app are set to lose focus closing the keyboard when they're tapped outside. I can't do the same on SearchBar as the onTapOutside property of TextField class is not exposed.

   Proposal

   Introduce onTextOutside parameter for SearchBar and SearchAnchor constructors.

   Do you have any other use cases (other than losing the focus) for which you want the onTapOutside parameter to be exposed by the Searchbar constructor?
   If you only want to unfocus it on being tapped outside, this can be implemented internally in the search bar class, and then there would be no need to expose the parameter.
3. Sahil-kachhap commented on Mar 15, 2024

   

   Sahil-kachhap

   on Mar 15, 2024

   Last edited by Sahil-kachhap

   Contributor

   More actions

   WhatsApp.Video.2024-03-15.at.6.59.45.PM.mp4

   Here's a fix I have implemented @danagbemava-nc @darshankawar, Let me know if this looks good to go.
   And here's what I have done: I utilize the focusNode property of searchbar class and then I use it in onTapOutside property of underlying textfield.

   onTapOutside: _focusNode.unfocus();
   

   the change has been made here - just added a parameter: onTapOutside
4. aleripe commented on Mar 18, 2024

   

   aleripe

   on Mar 18, 2024

   Author

   More actions

   Use case

   All the TextFields in my app are set to lose focus closing the keyboard when they're tapped outside. I can't do the same on SearchBar as the onTapOutside property of TextField class is not exposed.

   Proposal

   Introduce onTextOutside parameter for SearchBar and SearchAnchor constructors.

   Do you have any other use cases (other than losing the focus) for which you want the onTapOutside parameter to be exposed by the Searchbar constructor? If you only want to unfocus it on being tapped outside, this can be implemented internally in the search bar class, and then there would be no need to expose the parameter.

   I have no other use case at the moment, but I think it could be more useful to expose it rather than wrap it. But it's your choice!
5. CicciLeo commented on Mar 19, 2024

   

   CicciLeo

   on Mar 19, 2024

   More actions

   Use case

   All the TextFields in my app are set to lose focus closing the keyboard when they're tapped outside. I can't do the same on SearchBar as the onTapOutside property of TextField class is not exposed.

   Proposal

   Introduce onTextOutside parameter for SearchBar and SearchAnchor constructors.

   Do you have any other use cases (other than losing the focus) for which you want the onTapOutside parameter to be exposed by the Searchbar constructor? If you only want to unfocus it on being tapped outside, this can be implemented internally in the search bar class, and then there would be no need to expose the parameter.

   It can be usefull if you want to clear the SearchController value if you tap outside, and keep the text only on submit
6. Sahil-kachhap commented on Mar 19, 2024

   

   Sahil-kachhap

   on Mar 19, 2024

   Contributor

   More actions

   Thanks @aleripe @CicciLeo for sharing this usecase, I will make the relevant changes in the PR based on your responses.

   ❤️React with ❤️1Reacted by CicciLeo
7. auto-submit

   closed this as completedin #145232on Mar 25, 2024
8. auto-submit

   added a commit that references this issue on Mar 25, 2024

   [Fix]: Searchbar doesn't lose focus when tapped outside (#145232)

   ...

   This issue will close once commit a9f18b8 is merged into the 'master' branch.

   a9f18b8
9. danagbemava-nc

   added

   r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version

   on Mar 26, 2024
10. github-actions commented on Apr 9, 2024

    

    github-actionsbot

    on Apr 9, 2024 – with GitHub Actions

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
11. github-actions

    locked as resolved and limited conversation to collaborators on Apr 9, 2024