RenderParagraph.getFullHeightForCaret and TextPainter.getFullHeightForCaret shouldn't be nullable

The getFullHeightForCaret declared in RenderParagraph and TextPainter has a return type of double?, but looking at the implementation it seems it couldn't possibly return null:

flutter/packages/flutter/lib/src/rendering/paragraph.dart

Lines 952 to 959 in 274152f

    
             /// {@macro flutter.painting.textPainter.getFullHeightForCaret} 
        
             /// 
        
             /// Valid only after [layout]. 
        
             double? getFullHeightForCaret(TextPosition position) { 
        
               assert(!debugNeedsLayout); 
        
               _layoutTextWithConstraints(constraints); 
        
               return _textPainter.getFullHeightForCaret(position, Rect.zero); 
        
             }

flutter/packages/flutter/lib/src/painting/text_painter.dart

Lines 1350 to 1358 in 274152f

    
             /// {@template flutter.painting.textPainter.getFullHeightForCaret} 
        
             /// Returns the strut bounded height of the glyph at the given `position`. 
        
             /// {@endtemplate} 
        
             /// 
        
             /// Valid only after [layout] has been called. 
        
             double? getFullHeightForCaret(TextPosition position, Rect caretPrototype) { 
        
               final TextBox textBox = _getOrCreateLayoutTemplate().getBoxesForRange(0, 1, boxHeightStyle: ui.BoxHeightStyle.strut).single; 
        
               return textBox.toRect().height; 
        
             }

If the return type must be nullable, then it should be documented why. Otherwise, the return type should be changed to double.

Fix nullability of getFullHeightForCaret (#145554)

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

Navigation Menu

Repository navigation

`RenderParagraph.getFullHeightForCaret` and `TextPainter.getFullHeightForCaret` shouldn't be nullable #145507

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	/// {@macro flutter.painting.textPainter.getFullHeightForCaret}
	///
	/// Valid only after [layout].
	double? getFullHeightForCaret(TextPosition position) {
	assert(!debugNeedsLayout);
	_layoutTextWithConstraints(constraints);
	return _textPainter.getFullHeightForCaret(position, Rect.zero);
	}

	/// {@template flutter.painting.textPainter.getFullHeightForCaret}
	/// Returns the strut bounded height of the glyph at the given `position`.
	/// {@endtemplate}
	///
	/// Valid only after [layout] has been called.
	double? getFullHeightForCaret(TextPosition position, Rect caretPrototype) {
	final TextBox textBox = _getOrCreateLayoutTemplate().getBoxesForRange(0, 1, boxHeightStyle: ui.BoxHeightStyle.strut).single;
	return textBox.toRect().height;
	}

RenderParagraph.getFullHeightForCaret and TextPainter.getFullHeightForCaret shouldn't be nullable #145507

Description

Activity

github-actions commented on Apr 5, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`RenderParagraph.getFullHeightForCaret` and `TextPainter.getFullHeightForCaret` shouldn't be nullable #145507