Skip to content

[in_app_purchase] Remove JSON code from Android wrapper objects #146202

Closed
Closed
[in_app_purchase] Remove JSON code from Android wrapper objects#146202
Labels
P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.p: in_app_purchasePlugin for in-app purchasep: requires breaking changeA change that should be batched into the next breaking change to this packagepackageflutter/packages repository. See also p: labels.r: solvedIssue is closed as solvedteam-androidOwned by Android platform teamtriaged-androidTriaged by Android platform team

Description

@stuartmorgan-g
stuartmorgan-g
opened on Apr 3, 2024

The original Android implementation of IAP created the Dart wrapper objects, which are the public API for clients to interact directly with the Android SDK (rather than the higher-level abstraction of the app-facing package, which isn't always sufficient), directly from platform channel JSON serialization. The platform communication has since been converted to Pigeon, but since the JSON methods were public methods on public classes, we couldn't remove them without a breaking change, so they were deprecated instead.

We should, either the next time we are doing a breaking change to the Android implementation anyway, or just as a breaking change to do the cleanup at some point (I would not expect the vast majority of clients to actually be broken by the change, since they would have to have decided to directly used the JSON for some reason, so it should be pretty low-cost).

Activity

  1. stuartmorgan-g
    added
    p: in_app_purchasePlugin for in-app purchase
    packageflutter/packages repository. See also p: labels.
    c: tech-debtTechnical debt, code quality, testing, etc.
    p: requires breaking changeA change that should be batched into the next breaking change to this package
    team-androidOwned by Android platform team
    on Apr 3, 2024
  2. auto-submit
    added a commit that references this issue on Apr 8, 2024

    [in_app_purchase] Convert Android data objects to Pigeon (#6453)

    583f8dd
  3. gmackall
    added
    P2Important issues not at the top of the work list
    triaged-androidTriaged by Android platform team
    on Apr 11, 2024
  4. TecHaxter
    added a commit that references this issue on May 22, 2024

    [in_app_purchase] Convert Android data objects to Pigeon (flutter#6453)

    0934981

  5. RobertOdrowaz commented on Feb 14, 2025

    @RobertOdrowaz
    RobertOdrowaz
    on Feb 14, 2025
    Contributor

    The JSON serialization has been removed from the Android implementation as part of Google Play Billing library update #8218

  6. RobertOdrowaz
    closed this as completedon Feb 14, 2025
  7. RobertOdrowaz
    added
    r: solvedIssue is closed as solved
    on Feb 14, 2025

  8. github-actions commented on Feb 28, 2025

    @github-actions
    github-actionsbot
    on Feb 28, 2025 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. github-actions
    locked as resolved and limited conversation to collaborators on Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.p: in_app_purchasePlugin for in-app purchasep: requires breaking changeA change that should be batched into the next breaking change to this packagepackageflutter/packages repository. See also p: labels.r: solvedIssue is closed as solvedteam-androidOwned by Android platform teamtriaged-androidTriaged by Android platform team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions