Skip to content

Windows_android native_assets_android is 2.00% flaky #146236

Description

@fluttergithubbot

The post-submit test builder Windows_android native_assets_android had a flaky ratio 2.00% for the past (up to) 100 commits, which is above our 2.00% threshold.

One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20native_assets_android/990
Commit: bca1d6a

Flaky builds:
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20native_assets_android/990
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20native_assets_android/981

Recent test runs:
https://flutter-dashboard.appspot.com/#/build?taskFilter=Windows_android%20native_assets_android

Please follow https://github.com/flutter/flutter/wiki/Reducing-Test-Flakiness#fixing-flaky-tests to fix the flakiness and enable the test back after validating the fix (internal dashboard to validate: go/flutter_test_flakiness).

Activity

  1. added
    c: flakeTests that sometimes, but not always, incorrectly pass
    P0Critical issues such as a build break or regression
    on Apr 3, 2024
  2. dcharkes commented on Apr 4, 2024

    @dcharkes
    Contributor
    [2024-03-29 12:48:42.813650] [STDOUT] stderr: [        ] Caused by: java.lang.OutOfMemoryError: Java heap space
    [2024-03-29 12:48:42.813650] [STDOUT] stderr: [        ] 	at java.base/java.io.ByteArrayOutputStream.<init>(ByteArrayOutputStream.java:81)
    [2024-03-29 12:48:42.813650] [STDOUT] stderr: [        ] 	at com.android.zipflinger.NoCopyByteArrayOutputStream.<init>(NoCopyByteArrayOutputStream.java:27)
    

    That doesn't sound good for a small testing app.

    <ffi_package_name>/example/android/gradle.properties:

    org.gradle.jvmargs=-Xmx4G
    android.useAndroidX=true
    android.enableJetifier=true
    

    I believe this should give the JVM 4 GB of memory.

    In the logs I see 11 times -Xmx4G and one time -Xmx512m the latter one the last mention of -Xmx before the OutOfMemoryError.

  3. dcharkes commented on Apr 4, 2024

    @dcharkes
    Contributor

    Similar issue:

    @stuartmorgan @reidbaker It is suspect that Gradle Worker Daemon 1 has a different heap limit. I have no clue where this worker is coming from though. Any insights?

  4. reidbaker commented on Apr 4, 2024

    @reidbaker
    Contributor

    @gmackall we found that you needed to set several flags at once or the others defaulted to tiny values. Do you remember where we found that bug?

  5. reidbaker commented on Apr 4, 2024

    @reidbaker
    Contributor

    @dcharkes try org.gradle.jvmargs=-Xmx4G -XX:MaxMetaspaceSize=2G -XX:+HeapDumpOnOutOfMemoryError

  6. dcharkes commented on Apr 4, 2024

    @dcharkes
    Contributor

    @dcharkes try org.gradle.jvmargs=-Xmx4G -XX:MaxMetaspaceSize=2G -XX:+HeapDumpOnOutOfMemoryError

    It is the default app template that is used for the plugin_ffi example:

    https://github.com/flutter/flutter/blob/master/packages/flutter_tools/templates/app_shared/android.tmpl/gradle.properties.tmpl

    org.gradle.jvmargs=-Xmx4G -XX:+HeapDumpOnOutOfMemoryError
    android.useAndroidX=true
    android.enableJetifier=true
    

    I can make a PR to change that one.

  7. gmackall commented on Apr 4, 2024

    @gmackall
    Member

    @gmackall we found that you needed to set several flags at once or the others defaulted to tiny values. Do you remember where we found that bug?

    Looks like you already found the answer, but context was in the description of this PR #143085

  8. reidbaker commented on Apr 4, 2024

    @reidbaker
    Contributor

    @dcharkes I am going to close this issue as fixed and let the bot reopen if it continues to flake.

  9. dcharkes commented on Apr 4, 2024

    @dcharkes
    Contributor

    Does the bot automatically mark the test as unflaky? I don't think I updated that status file.

    Edit: This one: https://github.com/flutter/flutter/pull/146237/files

  10. github-actions commented on Apr 18, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  11. locked as resolved and limited conversation to collaborators on Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P0Critical issues such as a build break or regressionc: flakeTests that sometimes, but not always, incorrectly passteam-androidOwned by Android platform team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions