[Proposal] Reduce warnings in flutter.groovy file

Use case

right now (using flutter 3.19.6) when opening the android module in android studio the flutter.groovy file located inside ...\flutter\packages\flutter_tools\gradle\src\main\groovy\flutter.groovy needs some refactoring and cleaning because it has more then 70 warnings right now (some libraries are deprecated,some unused methods ...):
i couldn't upload the code cz github has a limit in the body length so it's here

Proposal

the updated version can be found here
note that i haven't change or delete any function or messed any kind of logic just cleaned a bit and did as same as here to get rid of buildDir deprecation(there is now 31 warnings )

also something strange is here (that ididn't touch )

private String resolveProperty(String name, String defaultValue) {
        if (localProperties == null) {
            localProperties = readPropertiesIfExist(new File(project.projectDir.parentFile, "local.properties"))
        }
        String result
        if (project.hasProperty(name)) {
            result = project.property(name)
        }
        if (result == null) {
            result = localProperties.getProperty(name)
        }
        if (result == null) {
            result = defaultValue
        }
        return result
    }

i've seen the flutter.groovy file inside the master branch and it has less errors and i've tried to make it better here(not tested yet i have some issues i'll try using the branch master and track it )

Thanks for the proposal. This is number of warnings I see when opening that file on Android Studio:

Flutter stable 3.19.6: 61 warnings
Flutter master channel 3.22.0-14.0.pre.67: 24 warnings

reduce warnings inside flutter.groovy file (flutter#152073)

fix `Consider using 'named' to avoid unnecessary configuration` insid…

small update in regex in flutter.groovy (#156484)

Update flutter.groovy to catch unknown task exception when finding ap…

small update in regex in flutter.groovy (flutter#156484)

Readability change to `flutter.groovy`, align on null assignment, red…

Removing redundant backticks in `flutter\packages\flutter_tools\gradl…

fix fialing lint `Consider using 'register' to avoid unnecessary conf…

Since this file does not exist any more ....

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

Navigation Menu

Repository navigation

[Proposal] Reduce warnings in flutter.groovy file #147122

Use case

Proposal

10 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Proposal] Reduce warnings in flutter.groovy file #147122

Description

Use case

Proposal

Activity

AbdeMohlbi commented on Apr 20, 2024

AbdeMohlbi commented on Apr 20, 2024

huycozy commented on Apr 22, 2024

10 remaining items

AbdeMohlbi commented on May 15, 2025

github-actions commented on May 30, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions