Repository navigation
[go_router_builder] Compile-time exception when using not null List #149675
Description
Steps to reproduce
Run the code sample example.
Expected results
static ListRoute _fromState(GoRouterState state) => ListRoute(
ids: (state.uri.queryParametersAll['ids'] ?? const []).map(int.parse).toList(),
);or
static ListRoute _fromState(GoRouterState state) => ListRoute(
ids: switch(state.uri.queryParametersAll['ids']) {
null => const [],
final ids => ids.map((e) => int.parse(e)).toList(),
},
);Actual results
static ListRoute _fromState(GoRouterState state) => ListRoute(
ids: state.uri.queryParametersAll['ids']?.map(int.parse).toList(),
);Code sample
Code sample
import 'package:flutter/material.dart';
import 'package:go_router/go_router.dart';
part 'main.g.dart';
void main() => runApp(const App());
final GoRouter _router = GoRouter(
routes: $appRoutes,
initialLocation: '/splash',
);
class App extends StatelessWidget {
const App({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp.router(
routerConfig: _router,
);
}
}
@TypedGoRoute<ListRoute>(path: '/list')
class ListRoute extends GoRouteData {
const ListRoute({required this.ids});
final List<int> ids;
@override
Widget build(BuildContext context, GoRouterState state) =>
ListScreen(ids: ids);
}
class ListScreen extends StatelessWidget {
const ListScreen({super.key, required this.ids});
final List<int> ids;
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: const Text('List Example')),
body: Center(child: Text('Ids: $ids')),
);
}
}
@TypedGoRoute<SplashRoute>(path: '/splash')
class SplashRoute extends GoRouteData {
const SplashRoute();
@override
Widget build(BuildContext context, GoRouterState state) => const Splash();
}
class Splash extends StatelessWidget {
const Splash({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: const Text('Splash')),
body: Center(
child: ElevatedButton(
onPressed: () => const ListRoute(ids: [1,2]).go(context),
child: const Text('List Example'),
),
),
);
}
}
Screenshots or Video
Screenshots / Video demonstration
[Upload media here]
Logs
Logs
[Paste your logs here]Flutter Doctor output
Doctor output
[√] Flutter (Channel stable, 3.22.0, on Microsoft Windows [Version 10.0.22631.3672], locale pt-PT)
• Flutter version 3.22.0 on channel stable at C:\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 5dcb86f68f (4 weeks ago), 2024-05-09 07:39:20 -0500
• Engine revision f6344b75dc
• Dart version 3.4.0
• DevTools version 2.34.3
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at C:\Users\Eu\AppData\Local\Android\sdk
• Platform android-34, build-tools 34.0.0
• Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
• Java version OpenJDK Runtime Environment (build 17.0.10+0--11572160)
• All Android licenses accepted.
[√] Chrome - develop for the web
• CHROME_EXECUTABLE = C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe
[√] Visual Studio - develop Windows apps (Visual Studio Build Tools 2019 16.11.22)
• Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools
• Visual Studio Build Tools 2019 version 16.11.33130.400
• Windows 10 SDK version 10.0.19041.0
[√] Android Studio (version 2023.3)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.10+0--11572160)
[√] VS Code, 64-bit edition (version 1.89.1)
• VS Code at C:\Program Files\Microsoft VS Code
• Flutter extension version 3.88.0
[√] Connected device (4 available)
• Redmi Note 9S (mobile) • 14f27be • android-arm64 • Android 12 (API 31)
• Windows (desktop) • windows • windows-x64 • Microsoft Windows [Version 10.0.22631.3672]
• Chrome (web) • chrome • web-javascript • unknown
• Edge (web) • edge • web-javascript • Microsoft Edge 125.0.2535.79
[√] Network resources
• All expected network resources are available.
• No issues found!Metadata
Metadata
Assignees
Labels
Bot is counting down the days until it unassigns the issueImportant issues not at the top of the work listFound to occur in 3.22Found to occur in 3.23The issue has been confirmed reproducible and is ready to work onThe go_router_builder packageflutter/packages repository. See also p: labels.Issue is closed as solved
Activity
darshankawar commentedon Jun 5, 2024
@rubenferreira97 Can you provide this file / code ?
rubenferreira97 commentedon Jun 5, 2024
@darshankawar Here it is:
You can also run
dart run build_runner build -dwith the provided code, assumingbuild_runner,go_router_builderandgo_routerare present onpubspec.yaml.This produces the following error:
darshankawar commentedon Jun 5, 2024
Thanks for the update. I was able to replicate the reported behavior.
stable, master flutter doctor -v
flutter-triage-bot commentedon Nov 21, 2024
This issue is assigned to @hannah-hyj but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!
[go_router_builder] Add a fallback for a not null List or Set param (#…
github-actions commentedon Jan 23, 2025
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.