Skip to content

[dart2wasm] iFrame locks position on transition into view #149909

Closed
Closed
[dart2wasm] iFrame locks position on transition into view#149909
Assignees
eyebrowsoffire
Labels
P1High-priority issues at the top of the work liste: wasmIssues related to the wasm build of Flutter Web.e: web_skwasmSkwasm rendering backend for webplatform-webWeb applications specificallyr: solvedIssue is closed as solvedteam-webOwned by Web platform teamtriaged-webTriaged by Web platform team

Description

@kenzieschmoll
kenzieschmoll
opened on Jun 7, 2024

Original issue filed on the Dart SDK repo - creating this issue to transfer to the Flutter Web team. From discussion on the original issue, it appears this may be the result of #133466.

Copied from original issue:

In DevTools, we use iFrames for a couple of features:

  1. The embedded Perfetto trace viewer on the Performance page
  2. DevTools extensions

In both cases, the iFrame is transitioned into view by a Flutter tab view. Upon selecting the "Timeline Events" tab on the Performance page or upon selecting a top level tab for a DevTools extension, the iFrame locks its position before fully transitioning into view:
Screenshot 2024-06-05 at 9 56 17 AM
Screenshot 2024-06-05 at 9 55 52 AM

Requirements:

  • Pull the latest code from the flutter/devtools master branch
  • Pull the latest code from the Dart SDK (or patch this change if it has not landed yet.)
  • Set up your DevTools environment so that
    • You have access to the devtools_tool executable - docs
    • You have the LOCAL_DART_SDK environment variable set - docs

Repro steps:

  1. Build DevTools from source with wasm: devtools_tool serve --wasm. If you want to build with --no-strip-wasm, add the flag here before serving DevTools.
  2. Run the Flutter gallery app (this app depends on package:provider, which has a DevTools extension)
  3. Copy the VM service URI from the Flutter gallery app and connect it to the DevTools instance you just served with wasm.
  4. Navigate to either the Performance screen > Timeline Events OR to the top level Provider screen tab (should be present as long as you are running flutter gallery) to observe the incorrect iFrame position.

If this does not repro on the first try, refresh the DevTools window in the browser and try again.

Activity

  1. darshankawar
    added
    in triagePresently being triaged by the triage team
    on Jun 10, 2024

  2. darshankawar commented on Jun 10, 2024

    @darshankawar
    darshankawar
    on Jun 10, 2024
    Member

    Requirements:

    • Pull the latest code from the flutter/devtools master branch

    • Pull the latest code from the Dart SDK (or patch this change if it has not landed yet.)

    • Set up your DevTools environment so that

      • You have access to the devtools_tool executable - docs
      • You have the LOCAL_DART_SDK environment variable set - docs

    Repro steps:

    1. Build DevTools from source with wasm: devtools_tool serve --wasm. If you want to build with --no-strip-wasm, add the flag here before serving DevTools.
    2. Run the Flutter gallery app (this app depends on package:provider, which has a DevTools extension)
    3. Copy the VM service URI from the Flutter gallery app and connect it to the DevTools instance you just served with wasm.
    4. Navigate to either the Performance screen > Timeline Events OR to the top level Provider screen tab (should be present as long as you are running flutter gallery) to observe the incorrect iFrame position.

    If this does not repro on the first try, refresh the DevTools window in the browser and try again.

    I will try to follow these steps and see if I can replicate it or not. Currently, based on the report, labeling for team's attention.

  3. darshankawar
    added
    platform-webWeb applications specifically
    e: wasmIssues related to the wasm build of Flutter Web.
    team-webOwned by Web platform team
    e: web_skwasmSkwasm rendering backend for web
    and removed
    in triagePresently being triaged by the triage team
    on Jun 10, 2024
  4. yjbanov
    added
    P2Important issues not at the top of the work list
    triaged-webTriaged by Web platform team
    on Jun 13, 2024
  5. eyebrowsoffire
    self-assigned this
    on Jul 12, 2024
  6. yjbanov
    added
    P1High-priority issues at the top of the work list
    and removed
    P2Important issues not at the top of the work list
    on Aug 1, 2024

  7. eyebrowsoffire commented on Aug 1, 2024

    @eyebrowsoffire
    eyebrowsoffire
    on Aug 1, 2024
    Contributor

    I think this should be resolved after #152139. @kenzieschmoll can you confirm?

  8. kenzieschmoll commented on Aug 7, 2024

    @kenzieschmoll
    kenzieschmoll
    on Aug 7, 2024
    MemberAuthor

    Confirmed this is resolved on

    Flutter 3.24.0-1.0.pre.441 • channel master • [email protected]:flutter/flutter.git
Framework • revision 0e720e84a4 (2 days ago) • 2024-08-05 14:56:14 +0100
Engine • revision 0aac603420
Tools • Dart 3.6.0 (build 3.6.0-114.0.dev) • DevTools 2.38.0

  9. darshankawar commented on Aug 8, 2024

    @darshankawar
    darshankawar
    on Aug 8, 2024
    Member

    Closing as resolved.

  10. darshankawar
    closed this as completedon Aug 8, 2024
  11. darshankawar
    added
    r: solvedIssue is closed as solved
    on Aug 8, 2024

  12. github-actions commented on Aug 22, 2024

    @github-actions
    github-actionsbot
    on Aug 22, 2024 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  13. github-actions
    locked as resolved and limited conversation to collaborators on Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work liste: wasmIssues related to the wasm build of Flutter Web.e: web_skwasmSkwasm rendering backend for webplatform-webWeb applications specificallyr: solvedIssue is closed as solvedteam-webOwned by Web platform teamtriaged-webTriaged by Web platform team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions