Skip to content

[tool] some tests test for sending GA3 analytics events but not GA4 #150665

Closed

Description

@andrewkolos

Discovered while working on #150575

Example:

testUsingContext('logs success', () async {
final String projectPath = await createProject(tempDir,
arguments: <String>['--no-pub', '--template=app']);
await runBuildApkCommand(projectPath);
expect(testUsage.events, contains(
const TestUsageEvent(
'tool-command-result',
'apk',
label: 'success',
),
));
},

I'm assuming these tests should be making sure we are sending GA4 events as well (using package:unified_analytics).

Activity

  1. added
    P2Important issues not at the top of the work list
    c: tech-debtTechnical debt, code quality, testing, etc.
    team-toolOwned by Flutter Tool team
    triaged-toolTriaged by Flutter Tool team
    on Jun 23, 2024
  2. self-assigned this
    on Jun 23, 2024
  3. changed the title [-][tool] some tests in build_apk_test.dart test for sending GA3 analytics events but not GA4[/-] [+][tool] some tests test for sending GA3 analytics events but not GA4[/+] on Jun 23, 2024
  4. removed their assignment
    on Aug 23, 2024
  5. self-assigned this
    on Jan 29, 2025
  6. andrewkolos commented on Feb 5, 2025

    @andrewkolos
    ContributorAuthor

    Fixed by various PRs associated with #150575

  7. github-actions commented on Feb 19, 2025

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. locked as resolved and limited conversation to collaborators on Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.team-toolOwned by Flutter Tool teamtriaged-toolTriaged by Flutter Tool team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions