Skip to content

[tool] ErrorHandlingFileSystem::systemTempDirectory does not return an ErrorHandlingDirectory #150730

Description

@andrewkolos

See title. ErrorHandlingFileSystem doesn't override FileSystem::systemTempDirectory. This means that any tool code utilizing FileSystem::systemTempDirectory doesn't benefit from the error-handling provided by ErrorHandlingDirectory. It is possible that this is resulting in noisy, inactionable tool crashes from file system exceptions caused by things such as permissions issues.

Activity

  1. added
    toolAffects the "flutter" command-line tool. See also t: labels.
    P1High-priority issues at the top of the work list
    team-toolOwned by Flutter Tool team
    triaged-toolTriaged by Flutter Tool team
    on Jun 24, 2024
  2. self-assigned this
    on Jun 24, 2024
  3. andrewkolos commented on Jun 26, 2024

    @andrewkolos
    ContributorAuthor

    I don't know if this is something that users encounter (and I'm not going to spend time figuring out how to query this, but I really hope that most users have read/write permissions to their system's temp directory).

    At the very least, however, this has bit me when writing tests that 1) use systemTempDirectory and 2) use a fake/memory file system with a custom opHandle that throws an exception.

  4. github-actions commented on Jul 11, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  5. locked as resolved and limited conversation to collaborators on Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-toolTriaged by Flutter Tool team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions