Skip to content

Consider a flutter/flutter/packages/_flutter_common #152257

Closed as not planned
Closed as not planned
Consider a flutter/flutter/packages/_flutter_common#152257
Assignees
matanlurey
Labels
P3Issues that are less important to the Flutter projectc: proposalA detailed proposal for a change to Flutterc: tech-debtTechnical debt, code quality, testing, etc.e: scenario-appThe `testing/scenario_app` fixture in the engineinfra: device labInfrastructure device lab problemst: flutter driver"flutter driver", flutter_drive, or a driver testtoolAffects the "flutter" command-line tool. See also t: labels.

Description

@matanlurey
matanlurey
opened on Jul 24, 2024

As part of #152194, we discussed there are several sources of duplicated code in the Flutter SDK internals, particularly around things like "working with ADB", "parsing Gradle logs", "understanding exit codes", and "comparing golden files".

One suggestion was the creation of a flutter/flutter/packages/_flutter_common (the actual name should be better if able).

It's not clear what the scope of this package would be, how we would maintain it, who would be responsible for it, and how to stop it devolving from a utils folder, but it's an idea on how to reduce some code duplication. This issue is tracking ideas or suggestions towards that end, and I'll revisit it at the end of Q3 to see if there is a viable path.

/cc @christopherfujino @jonahwilliams @andrewkolos @johnmccutchan @gaaclarke @jmagman @Piinks

Activity

  1. matanlurey
    added
    toolAffects the "flutter" command-line tool. See also t: labels.
    t: flutter driver"flutter driver", flutter_drive, or a driver test
    c: proposalA detailed proposal for a change to Flutter
    P3Issues that are less important to the Flutter project
    c: tech-debtTechnical debt, code quality, testing, etc.
    infra: device labInfrastructure device lab problems
    e: scenario-appThe `testing/scenario_app` fixture in the engine
    on Jul 24, 2024
  2. matanlurey
    self-assigned this
    on Jul 24, 2024

  3. matanlurey commented on Sep 10, 2024

    @matanlurey
    matanlurey
    on Sep 10, 2024
    ContributorAuthor

    I am closing this as not planned at the moment.

  4. matanlurey
    closed this as not plannedon Sep 10, 2024

  5. github-actions commented on Sep 24, 2024

    @github-actions
    github-actionsbot
    on Sep 24, 2024 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. github-actions
    locked as resolved and limited conversation to collaborators on Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P3Issues that are less important to the Flutter projectc: proposalA detailed proposal for a change to Flutterc: tech-debtTechnical debt, code quality, testing, etc.e: scenario-appThe `testing/scenario_app` fixture in the engineinfra: device labInfrastructure device lab problemst: flutter driver"flutter driver", flutter_drive, or a driver testtoolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions