Skip to content

[CP] Emit source maps for wasm in flutter build web --wasm #153308

Closed
Closed
[CP] Emit source maps for wasm in flutter build web --wasm#153308
Assignees
itsjustkevin
Labels
cp: approvedApproved cherry-pick requestcp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Description

@mkustermann
mkustermann
opened on Aug 12, 2024

Issue Link

dart-lang/sdk#55763

Target

stable

PR Link

#153310

Changelog Description

This adds source map support in flutter run / flutter build for dart2wasm. This is very helpful for debugging in Chrome DevTools.

Impacted Users

Flutter web wasm users

Impact Description

Just knowing the function name and looking at huge wasm bytecode bodies is making it very hard for users to track e.g. where exactly exceptions are coming from, etc. Having source map support makes this much better as one can see dart sources as well as line & column numbers.

Workaround

No.

Risk

low

Test Coverage

yes

Validation Steps

No response

Activity

  1. mkustermann
    added
    cp: reviewCherry-picks in the review queue
    on Aug 12, 2024
  2. flutter-roll-on-borg
    assigned
    itsjustkevin
    on Aug 12, 2024

  3. mkustermann commented on Aug 12, 2024

    @mkustermann
    mkustermann
    on Aug 12, 2024
    MemberAuthor

    /cc @yjbanov @kevmoo

  4. mkustermann commented on Aug 12, 2024

    @mkustermann
    mkustermann
    on Aug 12, 2024
    MemberAuthor

    The PR can land once the current dart-lang/sdk@stable was rolled upstream into engine & framework stable branches.

  5. auto-submit
    added a commit that references this issue on Aug 13, 2024

    [CP Stable] Emit source maps for wasm in `flutter build web --wasm` (#…

    ec5d407
  6. itsjustkevin
    added
    cp: approvedApproved cherry-pick request
    cp: mergedCherry-pick has been merged to the release branch.
    on Aug 13, 2024
  7. itsjustkevin
    closed this as completedon Aug 21, 2024

  8. github-actions commented on Sep 4, 2024

    @github-actions
    github-actionsbot
    on Sep 4, 2024 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. github-actions
    locked as resolved and limited conversation to collaborators on Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions