Repository navigation
RPCError: setLibraryDebuggable: (-32000) Service connection disposed #153473
Description
Umbrella issue: #153471. This particular stack trace has only been reported by 7 unique clients to-date (8/14) on 3.24.0.
Commands: flutter debug_adapter
RPCError: setLibraryDebuggable: (-32000) Service connection disposed
at VmService._call(vm_service.dart:1774)
at VmService.setLibraryDebuggable(vm_service.dart:1594)
at IsolateManager._sendLibraryDebuggables.<anonymous closure>(isolate_manager.dart:1059)
at <asynchronous gap>(async)
at Future.wait.<anonymous closure>(future.dart:534)
at <asynchronous gap>(async)
at IsolateManager._sendLibraryDebuggables(isolate_manager.dart:1047)
at <asynchronous gap>(async)
at Future.wait.<anonymous closure>(future.dart:534)
at <asynchronous gap>(async)
at IsolateManager._configureIsolate(isolate_manager.dart:552)
at <asynchronous gap>(async)
at IsolateManager.registerIsolate(isolate_manager.dart:246)
at <asynchronous gap>(async)
at IsolateManager.handleEvent(isolate_manager.dart:189)
at <asynchronous gap>(async)
at DartDebugAdapter.handleIsolateEvent(dart.dart:2504)
at <asynchronous gap>(async)
at DartDebugAdapter._withErrorHandling(dart.dart:2821)
at <asynchronous gap>(async)
Activity
DanTup commentedon Aug 19, 2024
I think https://dart-review.googlesource.com/c/sdk/+/381181 should fix this.
@bkonyi I do also wonder if we should introduce a specific error code for this kind of error - although that also risks breaking any existing error handling like this.
bkonyi commentedon Aug 19, 2024
I think we should consider adding specific error codes for these cases so we can avoid doing string comparisons.
[dds/dap] Treat "Service Connection Disposed" the same as "Client clo…
DanTup commentedon Aug 19, 2024
A fix has landed in dart-lang/sdk@212e49f, but we'll need to roll DDS into Flutter before it gets that.
Should we add a new constant to DDS for this kind of error before doing a release then (but not use it), and then we can update Flutter (and DAP) to handle that error code prior to actually changing the errors? I don't know how many other places might be handling errors like this that may also need updating, but I do think it'll ultimately be a better solution than the current string checks.
DanTup commentedon Aug 19, 2024
I did also wonder if we should reuse
kServiceDisappearedfor this... If "Service" here means a registered service and not the "VM Service" then it wouldn't technically be precise, but since it's most likely anyone handling that error also wants to handle this, it could make the change to a new error code slightly less breaking because existing code may already handle it.Handle "Service connection disposed" error from VmService disconnecti…
Handle "Service connection disposed" error from VmService disconnecti…
Handle "Service connection disposed" error from VmService disconnecti…
github-actions commentedon Sep 3, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.[dds/dap] Treat "Service Connection Disposed" the same as "Client clo…
[CP] [dds/dap] Treat "Service Connection Disposed" the same as "Clien…
[CP] [dds/dap] Treat "Service Connection Disposed" the same as "Clien…