Skip to content

Stale VERSION file inside the SDK shipped with Flutter #15348

Closed
Closed
Stale VERSION file inside the SDK shipped with Flutter#15348
Assignees
rmacnak-google
Labels
dependency: dartDart team may need to help usengineflutter/engine related. See also e: labels.

Description

@DanTup
DanTup
opened on Mar 9, 2018

Dart Code displays the contents of the VERSION file in the Dart SDK in the status bar. Sometime recently (possibly when Flutter switched to making its own SDK builds) it seems that this file became stale:

Dannys-MacBook:~ danny$ flutter --version
Flutter 0.1.6-pre.3 • channel master • https://github.com/DanTup/flutter.git
Framework • revision 7f03b9e41b (2 weeks ago) • 2018-02-23 12:49:57 -0800
Engine • revision ead227f118
Tools • Dart 2.0.0-dev.28.0.flutter-0b4f01f759
Dannys-MacBook:~ danny$ cat /Users/danny/Dev/Google/flutter/bin/cache/dart-sdk/version
2.0.0-edge.0d5cf900b021bf5c9fa593ffa12b15bcd1cc5fe0

The Dart SDK revision is 0b4f01f759 (confirmed by running dart --version) so not sure why the file is bad.

Dart Code uses this files because it's faster (and less troublesome) than spawning a process.

Activity

  1. aam commented on Mar 9, 2018

    @aam
    aam
    on Mar 9, 2018
    Member

    https://dart-review.googlesource.com/c/sdk/+/45921 with the potential fix.

  2. aam
    assigned
    rmacnak-google
    on Mar 9, 2018
  3. dart-bot
    added 2 commits that reference this issue on Mar 9, 2018

    [build] Declare dependency of the version strings on the current Git …

    c080951

    Revert "[build] Declare dependency of the version strings on the curr…

    439badf

  4. zanderso commented on Mar 10, 2018

    @zanderso
    zanderso
    on Mar 10, 2018
    Member

    These are different because https://github.com/dart-lang/sdk/blob/master/tools/make_version.py has different logic from https://github.com/dart-lang/sdk/blob/master/tools/write_version_file.py.

    We should probably eliminate https://github.com/dart-lang/sdk/blob/master/tools/write_version_file.py, and instead use https://github.com/dart-lang/sdk/blob/master/tools/make_version.py to write the version file to make sure that they both say the same thing.

  5. DanTup
    added a commit that references this issue on May 8, 2018

    Don't show Dart version in status bar for Flutter projects

    25c311e

  6. Hixie commented on Jun 8, 2018

    @Hixie
    Hixie
    on Jun 8, 2018
    Contributor

    What's the status of this issue?

  7. Hixie
    added this to the milestone on Jun 8, 2018
  8. Hixie
    added
    engineflutter/engine related. See also e: labels.
    dependency: dartDart team may need to help us
    on Jun 8, 2018

  9. DanTup commented on Jun 9, 2018

    @DanTup
    DanTup
    on Jun 9, 2018
    ContributorAuthor

    Still an issue. This is latest master:

    Dannys-MacBook:flutter danny$ flutter --version
Flutter 0.5.3-pre.18 • channel master • https://github.com/DanTup/flutter.git
Framework • revision 326caa5d22 (15 minutes ago) • 2018-06-09 03:39:27 -0400
Engine • revision 5d2f24aa5c
Tools • Dart 2.0.0-dev.60.0.flutter-a5e41681e5

Dannys-MacBook:flutter danny$ cat bin/cache/dart-sdk/version 
2.0.0-edge.c080951d45e79cd25df98036c4be835b284a269c

    a5e41681e5 is the correct version, which is from 4 days ago.
    c080951d45 is wrong, it's a commit from March.

  10. dart-bot
    added a commit that references this issue on Jun 11, 2018

    [build] Declare dependency of the version strings on the current Git …

    86db781
  11. rmacnak-google
    closed this as completedon Jul 25, 2018

  12. github-actions commented on Aug 15, 2021

    @github-actions
    github-actionsbot
    on Aug 15, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  13. github-actions
    locked as resolved and limited conversation to collaborators on Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

dependency: dartDart team may need to help usengineflutter/engine related. See also e: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions