Repository navigation
Zulip test needs to migrate to wide gamut flutter_color_models fork #154123
Description
Description
Part of the work of introducing wide gamut color to the framework is editing the Color API. That change got reverted because it is breaking customer test Zulip. The problem isn't the Zulip test per se, but a dependency of theirs, flutter_color_model (and its dependency color_model).
I've filed an issue with the color_model developer and posted a PR for them that fixes the issue. I haven't heard back from them yet though.
I need the Zulip test to migrate to the forked flutter_color_model and color_model or it will be disabled in 72 hours (as per our SLA).
I'm sending an email to the 2 listed contacts for that test too.
Remedy
The Zulip test will have to add dependency_overrides for the following packages: flutter_color_models, color_models.
The overrides are going to point to my branch, wide-gamut. You use the git directives in pubspec to point it to that fork. Those 2 packages also live in the same repo, so the ref and path directives will have to be used.
That fork of color_models is a breaking change so there may be some required changes in the Zulip test, but probably not. The changes can be found in the CHANGELOG.md for those packages.
Another option would just be to eliminate the dependency on flutter_color_models.
Activity
[-]Zulip test needs to migrate to flutter_color_models fork[/-][+]Zulip test needs to migrate to wide gamut `flutter_color_models` fork[/+]chrisbobbe commentedon Aug 27, 2024
Thank you for your investigation, your work on those dependencies, and your clear instructions!
@gnprice is on vacation this week, so I'll be the one to merge the fix in Zulip, which I plan to do ASAP and before the 72-hour mark (so Thursday 2024-08-29 at 10am PDT). I'll post here if I have any questions for you.
deps: Add some overrides to unblock Flutter Color API changes for wid…
chrisbobbe commentedon Aug 28, 2024
OK, merged zulip/zulip-flutter#920 in Zulip to follow your instructions.
Update zulip to unblock Color API change for wide-gamut
chrisbobbe commentedon Aug 28, 2024
Ah and just sent flutter/tests#404 to update the Zulip commit in the tests repo.
chrisbobbe commentedon Aug 28, 2024
I believe @gaaclarke is currently out of office, is there someone else who can review flutter/tests#404 ?
Update zulip to unblock Color API change for wide-gamut (#404)
github-actions commentedon Sep 12, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.