Skip to content

[webview_flutter_wkwebview] Legacy Video Playback Integration tests hang on iOS #154676

Open

Description

@bparrishMines

The legacy tests for inline video are failing to complete:

43:16 +45 ~1: ... Video playback policy Video plays inline when allowsInlineMediaPlayback is true                                                                                                      
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Video playback policy Video plays inline when allowsInlineMediaPlayback is true - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Video playback policy Video plays full screen when allowsInlineMediaPlayback is false - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Video playback policy (tearDownAll) - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Audio playback policy (setUpAll) - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Audio playback policy Auto media playback - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Audio playback policy Changes to initialMediaPlaybackPolicy are ignored - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Audio playback policy (tearDownAll) - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: getTitle - did not complete [E]          

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Programmatic Scroll setAndGetScrollPosition - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate can allow requests - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate onWebResourceError - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate onWebResourceError is not called with valid url - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate onWebResourceError only called for main frame - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate can block requests - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate supports asynchronous decisions - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: launches with gestureNavigationEnabled on iOS - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: target _blank opens in same window - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: can open new window and go back - did not complete [E]

43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: (tearDownAll) - did not complete [E]     

43:16 +45 ~1: Some tests failed.                                                                                                                                                                       

[packages/webview_flutter/webview_flutter_wkwebview completed in 43m 22s]

It seems only the legacy tests fail while the same test with the public API still passes.

I was able to reproduce it locally as well.

Activity

  1. added
    c: disabled testTracks the restoration of a disabled test
    platform-iosiOS applications specifically
    fyi-ecosystemFor the attention of Ecosystem team
    team-iosOwned by iOS platform team
    P3Issues that are less important to the Flutter project
    on Sep 5, 2024
  2. jmagman commented on Sep 5, 2024

    @jmagman
    Member

    @bparrishMines is this running in CI? I'm not familiar with how the legacy tests work.

  3. bparrishMines commented on Sep 5, 2024

    @bparrishMines
    ContributorAuthor

    @bparrishMines is this running in CI? I'm not familiar with how the legacy tests work.

    Yea it runs on CI. The test has been failing consistently and blocking the roller.

  4. jmagman commented on Sep 5, 2024

    @jmagman
    Member
  5. jmagman commented on Sep 5, 2024

    @jmagman
    Member

    @bparrishMines It hangs for me locally even on the last roll that succeeded. I'm in packages/packages/webview_flutter/webview_flutter_wkwebview/example and ran flutter test -v -d <my simulator id> integration_test and it still hung. Is it passing for you locally on that Flutter commit? Am I missing a setup step?

    https://github.com/flutter/packages/pull/7471/checks?check_run_id=29073666779
    https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8738971084563231617/+/u/Run_package_tests/drive_examples/stdout

  6. bparrishMines commented on Sep 5, 2024

    @bparrishMines
    ContributorAuthor

    @bparrishMines It hangs for me locally even on the last roll that succeeded. I'm in packages/packages/webview_flutter/webview_flutter_wkwebview/example and ran flutter test -v -d <my simulator id> integration_test and it still hung. Is it passing for you locally on that Flutter commit? Am I missing a setup step?

    https://github.com/flutter/packages/pull/7471/checks?check_run_id=29073666779 https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8738971084563231617/+/u/Run_package_tests/drive_examples/stdout

    Its hanging on the latest successful roll for me too when I run it locally. So it may not be caused by the Flutter version.

  7. loic-sharma commented on Sep 11, 2024

    @loic-sharma
    Member

    @bparrishMines what are the legacy tests? Is this something we should prioritize?

  8. bparrishMines commented on Sep 17, 2024

    @bparrishMines
    ContributorAuthor

    It depends. We no longer work on the legacy implementation and it is not available through the pub.dev public API. However, some teams may still use it internally. I'm hoping that only the test is broken and not the implementation. I will try and verify it manually soon when I get the chance. I would consider it low priority unless someone states that they are broken by this feature.

  9. bparrishMines commented on Oct 7, 2024

    @bparrishMines
    ContributorAuthor

    I made a basic example app with the legacy API and it does look like allowsInlineMediaPlayback still works. So it does look like there is something wrong with the test itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.c: disabled testTracks the restoration of a disabled testp: webviewThe WebView pluginpackageflutter/packages repository. See also p: labels.platform-iosiOS applications specificallyteam-iosOwned by iOS platform teamtriaged-iosTriaged by iOS platform team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions