Repository navigation
[webview_flutter_wkwebview] Legacy Video Playback Integration tests hang on iOS #154676
Copy link
Copy link
Open
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: disabled testTracks the restoration of a disabled testTracks the restoration of a disabled testp: webviewThe WebView pluginThe WebView pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-iosiOS applications specificallyiOS applications specificallyteam-iosOwned by iOS platform teamOwned by iOS platform teamtriaged-iosTriaged by iOS platform teamTriaged by iOS platform team
Description
The legacy tests for inline video are failing to complete:
43:16 +45 ~1: ... Video playback policy Video plays inline when allowsInlineMediaPlayback is true
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Video playback policy Video plays inline when allowsInlineMediaPlayback is true - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Video playback policy Video plays full screen when allowsInlineMediaPlayback is false - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Video playback policy (tearDownAll) - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Audio playback policy (setUpAll) - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Audio playback policy Auto media playback - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Audio playback policy Changes to initialMediaPlaybackPolicy are ignored - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Audio playback policy (tearDownAll) - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: getTitle - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Programmatic Scroll setAndGetScrollPosition - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate can allow requests - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate onWebResourceError - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate onWebResourceError is not called with valid url - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate onWebResourceError only called for main frame - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate can block requests - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate supports asynchronous decisions - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: launches with gestureNavigationEnabled on iOS - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: target _blank opens in same window - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: can open new window and go back - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: (tearDownAll) - did not complete [E]
43:16 +45 ~1: Some tests failed.
[packages/webview_flutter/webview_flutter_wkwebview completed in 43m 22s]
It seems only the legacy tests fail while the same test with the public API still passes.
I was able to reproduce it locally as well.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: disabled testTracks the restoration of a disabled testTracks the restoration of a disabled testp: webviewThe WebView pluginThe WebView pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-iosiOS applications specificallyiOS applications specificallyteam-iosOwned by iOS platform teamOwned by iOS platform teamtriaged-iosTriaged by iOS platform teamTriaged by iOS platform team
Activity
jmagman commentedon Sep 5, 2024
@bparrishMines is this running in CI? I'm not familiar with how the legacy tests work.
bparrishMines commentedon Sep 5, 2024
Yea it runs on CI. The test has been failing consistently and blocking the roller.
jmagman commentedon Sep 5, 2024
Found the link
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8738133358312560321/+/u/Run_package_tests/drive_examples/stdout
jmagman commentedon Sep 5, 2024
@bparrishMines It hangs for me locally even on the last roll that succeeded. I'm in
packages/packages/webview_flutter/webview_flutter_wkwebview/exampleand ranflutter test -v -d <my simulator id> integration_testand it still hung. Is it passing for you locally on that Flutter commit? Am I missing a setup step?https://github.com/flutter/packages/pull/7471/checks?check_run_id=29073666779
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8738971084563231617/+/u/Run_package_tests/drive_examples/stdout
bparrishMines commentedon Sep 5, 2024
Its hanging on the latest successful roll for me too when I run it locally. So it may not be caused by the Flutter version.
[extension_google_sign_in_as_googleapis_auth][google_maps_flutter_ios…
loic-sharma commentedon Sep 11, 2024
@bparrishMines what are the legacy tests? Is this something we should prioritize?
bparrishMines commentedon Sep 17, 2024
It depends. We no longer work on the legacy implementation and it is not available through the
pub.devpublic API. However, some teams may still use it internally. I'm hoping that only the test is broken and not the implementation. I will try and verify it manually soon when I get the chance. I would consider it low priority unless someone states that they are broken by this feature.bparrishMines commentedon Oct 7, 2024
I made a basic example app with the legacy API and it does look like
allowsInlineMediaPlaybackstill works. So it does look like there is something wrong with the test itself.[extension_google_sign_in_as_googleapis_auth][google_maps_flutter_ios…
[extension_google_sign_in_as_googleapis_auth][google_maps_flutter_ios…
[extension_google_sign_in_as_googleapis_auth][google_maps_flutter_ios…
[extension_google_sign_in_as_googleapis_auth][google_maps_flutter_ios…
[extension_google_sign_in_as_googleapis_auth][google_maps_flutter_ios…