Skip to content

[CP] Fix Drawer prematurely snapping #154722

Closed
Closed
[CP] Fix Drawer prematurely snapping#154722
Assignees
itsjustkevin
Labels
cp: approvedApproved cherry-pick requestcp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Description

@nate-thegrate
nate-thegrate
opened on Sep 6, 2024

Issue Link

#153851

Target

stable

Cherry pick PR Link

#154720

Changelog Description

The Drawer widget will snap completely open or shut after being dragged more than halfway.

Impacted Users

This affects everyone who has a Drawer widget in their mobile app.

Impact Description

Fortunately, the impact of this issue is limited to visual jank. But it will likely be widespread across app developers.

Workaround

There isn't a workaround for this.

Risk

low

Test Coverage

yes

Validation Steps

This fix is covered by the test added in the linked pull request. It also can be verified by opening a mobile Flutter app and dragging a Drawer open or shut.

Activity

  1. nate-thegrate
    added
    cp: reviewCherry-picks in the review queue
    on Sep 6, 2024
  2. flutter-roll-on-borg
    assigned
    itsjustkevin
    on Sep 6, 2024
  3. itsjustkevin
    added
    cp: approvedApproved cherry-pick request
    on Sep 11, 2024
  4. auto-submit
    added a commit that references this issue on Sep 11, 2024

    [CP-stable]Fix `Drawer` prematurely snapping (#154720)

    98ba471
  5. itsjustkevin
    added
    cp: mergedCherry-pick has been merged to the release branch.
    on Sep 11, 2024

  6. nate-thegrate commented on Sep 11, 2024

    @nate-thegrate
    nate-thegrate
    on Sep 11, 2024
    ContributorAuthor

    Probably should have set up that PR to auto-close this issue :)

  7. nate-thegrate
    closed this as completedon Sep 11, 2024

  8. github-actions commented on Sep 26, 2024

    @github-actions
    github-actionsbot
    on Sep 26, 2024 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. github-actions
    locked as resolved and limited conversation to collaborators on Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions