Repository navigation
ReplaceSurfaceProducer.Callback.onSurfaceCreated with onSurfaceAvailable when published to stable #155131
Description
Callback.SurfaceProducer.onSurfaceCreated reads:
Invoked when a previous surface is now invalid and a new surface is now available.
Unfortunately this (a) is not a true statement and (b) the method name sucks.
What this really is:
public FlutterRenderer(@NonNull FlutterJNI flutterJNI) {
this.flutterJNI = flutterJNI;
this.flutterJNI.addIsDisplayingFlutterUiListener(flutterUiDisplayListener);
ProcessLifecycleOwner.get()
.getLifecycle()
.addObserver(
new DefaultLifecycleObserver() {
@Override
public void onResume(@NonNull LifecycleOwner owner) {
Log.v(TAG, "onResume called; notifying SurfaceProducers");
for (ImageReaderSurfaceProducer producer : imageReaderProducers) {
if (producer.callback != null) {
producer.callback.onSurfaceCreated();
}
}
}
});
}A resume is not directly correlated with a surface creation.
Some possible ideas:
- Only call the method when the surface was previously destroyed
- Rename the method
onSurfaceAvailableoronSurfaceResumed
Activity
johnmccutchan commentedon Sep 13, 2024
I like
onSurfaceAvailableAdd `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated…
Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfa…
15 remaining items
stuartmorgan-g commentedon Dec 17, 2024
@nikorehnback You need to
flutter pub upgrade; treating warnings as errors invideo_player_androidis a bug that was fixed in 2.7.7, and you are still using 2.7.3.nikorehnback commentedon Dec 18, 2024
This seemed to help, thanks @stuartmorgan
Replace `onSurfaceCreated` with `onSurfaceAvailable`. (flutter#8384)
github-actions commentedon Jan 21, 2025
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.Replace `onSurfaceCreated` with `onSurfaceAvailable`. (flutter#8384)
Replace `onSurfaceCreated` with `onSurfaceAvailable`. (flutter#8384)
Replace `onSurfaceCreated` with `onSurfaceAvailable`. (flutter#8384)
Replace `onSurfaceCreated` with `onSurfaceAvailable`. (flutter#8384)
Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated…
Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfa…
Reverts "Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate…