Skip to content

Remove use_modular_headers! from Swift Podfiles #156259

Closed

Description

@loic-sharma

Background

We added use_modular_headers! to our Podfiles as we originally planned to phase out use_frameworks! (see #42204). However, our plans have now changed and we are instead phasing out CocoaPods entirely in favor of Swift Package Manager.

CocoaPods's use_frameworks! and use_modular_headers! are two different overlapping options that should not be used together. This change removes the use_modular_headers! from the macOS Podfile and the iOS Swift Podfile (the iOS Objective-C template was recently deprecated #155867).

Work

Remove use_modular_headers! from all Swift Podfiles.

Activity

  1. self-assigned this
    on Oct 4, 2024
  2. added
    P3Issues that are less important to the Flutter project
    team-iosOwned by iOS platform team
    triaged-iosTriaged by iOS platform team
    platform-iosiOS applications specifically
    toolAffects the "flutter" command-line tool. See also t: labels.
    platform-macosBuilding on or for macOS specifically
    on Oct 4, 2024
  3. navaronbracke commented on Oct 5, 2024

    @navaronbracke
    Contributor

    Would including a project migrator for apps be a good thing here? And do we need to modify the SPM migration docs to tell developers to remove it there as well?

  4. loic-sharma commented on Oct 7, 2024

    @loic-sharma
    MemberAuthor

    @navaronbracke While in theory this change is necessary, in practice we're not aware of any problems caused by this today. However, we are concerned that an automatic migration could break apps if not done well.

    For now, we'll fix new apps but not existing apps. Long-term, all existing apps will migrate to SwiftPM and won't be affected by this problem (removing use_modular_headers! is not a prerequisite for the SwiftPM migration). We want to put all our resources on getting the SwiftPM migration right :)

    Let me know if you have any concerns!

  5. github-actions commented on Dec 19, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P3Issues that are less important to the Flutter projectplatform-iosiOS applications specificallyplatform-macosBuilding on or for macOS specificallyteam-iosOwned by iOS platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-iosTriaged by iOS platform team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions