Skip to content

Move --no-implicit-pubspec-resolution to a Feature #158012

Closed
#158016
Closed
Move --no-implicit-pubspec-resolution to a Feature#158012
#158016
Assignees
matanlurey
Labels
P2Important issues not at the top of the work listblockedIssue is blocked by another issuec: tech-debtTechnical debt, code quality, testing, etc.f: integration_testThe flutter/packages/integration_test pluginteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.

Description

@matanlurey
matanlurey
opened on Nov 1, 2024

Blocked on #157462 landing first.

Similar to what was done for Swift Package Manager, e.g.

flutter config --explicit-package-resolution

Or later to opt-out:

flutter config --no-explicit-package-resolution

Advantages:

  • Fits the formula of "something we are rolling out" better.
  • Can be opt-out/in globally, or potentially per-project (i.e. using pubspec.yaml, which is additional custom work)

Disadvantages:

  • Slightly more work, slightly more cumbersome to integration test

Steps:

Feature flags are always positive things (adding a feature), so I'd want to call it explicit, explicit-package-resolution?

Activity

  1. matanlurey
    added
    toolAffects the "flutter" command-line tool. See also t: labels.
    f: integration_testThe flutter/packages/integration_test plugin
    P2Important issues not at the top of the work list
    blockedIssue is blocked by another issue
    c: tech-debtTechnical debt, code quality, testing, etc.
    team-toolOwned by Flutter Tool team
    on Nov 1, 2024
  2. matanlurey
    self-assigned this
    on Nov 1, 2024
  3. matanlurey
    closed this as completedin #158016on Nov 14, 2024
  4. matanlurey
    closed this as completedin 125b4e9on Nov 14, 2024
  5. fluttermirroringbot
    added a commit that references this issue on Nov 14, 2024

    Move explicit package dependencies to a feature flag (#158016)

    125b4e9

  6. github-actions commented on Nov 28, 2024

    @github-actions
    github-actionsbot
    on Nov 28, 2024 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. github-actions
    locked as resolved and limited conversation to collaborators on Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listblockedIssue is blocked by another issuec: tech-debtTechnical debt, code quality, testing, etc.f: integration_testThe flutter/packages/integration_test pluginteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions