Skip to content

[packages][tool] Analysis breaking after pubspec_parse change. #160799

Description

@ditman

I'm having some analyze repo tools failures in files that I haven't touched in flutter/packages (both in stable and master?)

See: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze%20stable/14294/overview

A couple of lints are failing:

  • invalid_null_aware_operator
  • unnecessary_non_null_assertion

@bparrishMines took a look and found the root cause:

It looks like the lint is caused by the pubspec_parse package. Their latest version made Pubspec.environment nonull: https://pub.dev/packages/pubspec_parse/changelog#140

Fix the tool.

Activity

  1. added
    toolAffects the "flutter" command-line tool. See also t: labels.
    packageflutter/packages repository. See also p: labels.
    P1High-priority issues at the top of the work list
    on Dec 23, 2024
  2. self-assigned this
    on Dec 23, 2024
  3. munrocket commented on Dec 23, 2024

    @munrocket
    Contributor

    Can confirm, my PR also broken. It can be prehook with analyze fix on each commit.

  4. munrocket commented on Dec 24, 2024

    @munrocket
    Contributor

    Still broken on PRs in tools ._.

  5. github-actions commented on Jan 7, 2025

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listpackageflutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamtoolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions