Skip to content

Remove dev_dependencys from generated plugin registrants on all platforms #161348

Closed

Description

@camsim99

#161343 will remove dev dependencies from the generated plugin registrant for Android as part of a fix for enabling dev dependncies being removed from release builds (#160407).

We should follow up that PR by doing the same for all platforms, just not Android. This is what the change for Android looked like for context:

Future<void> _writeAndroidPluginRegistrant(FlutterProject project, List<Plugin> plugins, {required bool releaseMode}) async {
  Iterable<Plugin> methodChannelPlugins = _filterMethodChannelPlugins(plugins, AndroidPlugin.kConfigKey);
  if (releaseMode) {
    methodChannelPlugins = methodChannelPlugins.where((Plugin p) => !p.isDevDependency);
  }

Activity

  1. added
    toolAffects the "flutter" command-line tool. See also t: labels.
    P1High-priority issues at the top of the work list
    team-androidOwned by Android platform team
    triaged-androidTriaged by Android platform team
    on Jan 8, 2025
  2. self-assigned this
    on Jan 8, 2025
  3. github-actions commented on Feb 13, 2025

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  4. locked as resolved and limited conversation to collaborators on Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listteam-androidOwned by Android platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-androidTriaged by Android platform team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions