Create an injectable flutter tool customization mechanism #16204

Activity

1. xster

   added

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   team: infra

   on Apr 4, 2018
2. tvolkert commented on Apr 4, 2018

   

   tvolkert

   on Apr 4, 2018

   Contributor

   More actions

   You want to use AppContext:

   flutter/packages/flutter_tools/lib/src/base/context.dart

   Line 47 in b8629ba

   class AppContext {

   You'd create some abstraction for whatever behavior you want to be swappable, then inject a default implementation of that abstraction here:

   flutter/packages/flutter_tools/lib/src/context_runner.dart

   Line 45 in b8629ba

   fallbacks: <Type, Generator>{

   Then vendors (or different places in flutter_tools) could call context.run(overrides: ...) to override the behavior provided by the abstraction.

   We do this already for things like Artifacts (or FileSystem in tests).
3. xster commented on Apr 4, 2018

   

   xster

   on Apr 4, 2018

   MemberAuthor

   More actions

   Where would the vendor injection code live? In a different google_flutter_tools repo?
4. tvolkert commented on Apr 4, 2018

   

   tvolkert

   on Apr 4, 2018

   Contributor

   More actions

   It's up to the vendor. Within Google, we have a shim main() that calls into flutter_tools::main() within an overridden context.
5. Hixie

   added

   c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.

   and removed

   team: infra

   on Apr 23, 2018
6. tvolkert commented on Dec 19, 2018

   

   tvolkert

   on Dec 19, 2018

   Contributor

   More actions

   Closing as a dup of #25377
7. tvolkert

   closed this as completedon Dec 19, 2018
8. github-actions commented on Aug 31, 2021

   

   github-actionsbot

   on Aug 31, 2021

   More actions

   This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
9. github-actions

   locked as resolved and limited conversation to collaborators on Aug 31, 2021