Tests in test/commands.shard/hermetic/config_test.dart make assertions against globals.analytics without actually injecting a value

Example:

flutter/packages/flutter_tools/test/commands.shard/hermetic/config_test.dart

Lines 252 to 255 in 5491c8c

    
               expect(fakeAnalytics.sentEvents, isEmpty); 
        
             }, 
        
             overrides: <Type, Generator>{Usage: () => testUsage}, 
        
           );

Notice we make an assertion against fakeAnalytics. If you view the full test code, you see this value is never injected into any object (or the context global via testUsingContext's overrides parameter).

delete references to `Usage` in config_test.dart (#162648)

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

Navigation Menu

Repository navigation

Tests in `test/commands.shard/hermetic/config_test.dart` make assertions against `globals.analytics` without actually injecting a value #162413

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	expect(fakeAnalytics.sentEvents, isEmpty);
	},
	overrides: <Type, Generator>{Usage: () => testUsage},
	);

Tests in test/commands.shard/hermetic/config_test.dart make assertions against globals.analytics without actually injecting a value #162413

Description

Activity

github-actions commented on Feb 18, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Tests in `test/commands.shard/hermetic/config_test.dart` make assertions against `globals.analytics` without actually injecting a value #162413