intellij_test is not hermetic #16339

Activity

1. tvolkert

   added

   a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our tests

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   team: flakes

   on Apr 7, 2018
2. tvolkert

   assigned

   scheglov

   on Apr 7, 2018
3. scheglov commented on Apr 7, 2018

   

   scheglov

   on Apr 7, 2018

   Contributor

   More actions

   1. I copied these tests from doctor_test.dart, which does not use overrides. Or do I miss them?

   2. These tests check presence and content of several jars, which we have in physical file system. How is this situation usually solved Flutter tests? It seems that copying them into MemoryFileSystem will not make them more hermetic, will it? Hm... Maybe I should instead just create jars inside of the test? Should not be too hard, we need just META-INF/plugin.xml in these jars.
4. tvolkert commented on Apr 7, 2018

   

   tvolkert

   on Apr 7, 2018

   ContributorAuthor

   More actions

   I copied these tests from doctor_test.dart, which does not use overrides

   Ah, makes sense - doctor_test.dart is blacklisted in Google because it's not hermetic 😄

   Yeah, creating jars inside the test would work.

   If this is meant to be more of an integration test, then we can leave it as-is and just blacklist it within Google. It looks like it's meant to be more of a unit test though.
5. scheglov

   closed this as completedon Apr 8, 2018
6. github-actions commented on Sep 3, 2021

   

   github-actionsbot

   on Sep 3, 2021

   More actions

   This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
7. github-actions

   locked as resolved and limited conversation to collaborators on Sep 3, 2021
8. flutter-triage-bot

   added

   c: flakeTests that sometimes, but not always, incorrectly passTests that sometimes, but not always, incorrectly pass

   on Jul 7, 2023