Repository navigation
Add additional interpolated values to custom devices commands #164454
Description
Use case
Flutter's support for custom devices makes it possible for (out-of-tree) custom embedders to hook into and integrate with the flutter run command.
However, this integration could be further improved if the flutter tool provided some additional (string interpolated) values that are typically required by custom devices and embedders:
- path to the ICU data file
Thefluttertool takes care of copying the ICU data file to the right location for each of the officially supported platforms and devices during the build process. However, that's not the case for custom devices and embedders so they need a way to locate the ICU data file. - engine revision
Similar to the above, custom devices and embedders need to manually manage the engine library (e.g.:libflutter_engine.so). Providing the engine version through the custom-device commands would avoid the need for some heuristics on the custom embedder side and should make it easier to keep it in sync with thefluttertool. - build mode
Currently custom devices only support thedebugbuild mode, but hopefully this is going to change in the future (Add support forprofileandreleaserun modes for custom devices #164228)
Proposal
Make the following (additional) string interpolated values available to the postBuild and runDebug custom device commands:
${icuDataPath}${engineRevision}${buildMode}
Activity
bkonyi commentedon Apr 8, 2025
This isn't something we're going to be able to prioritize on our size given that we plan to do some refactoring to the tool in the future that would likely make this issue irrelevant. However, there's no timeline on those refactors, so we'd be willing to accept a simple PR with tests to resolve this if you're interested in contributing a fix.
vially commentedon Apr 8, 2025
@bkonyi Thank you for your reply. There is a pending pull-request that implements this at #164455.
bkonyi commentedon Apr 9, 2025
Ah sorry, I missed that there was PR linked here. Thank you!
Add `buildMode`, `icuDataPath` and `engineRevision` interpolations fo…
github-actions commentedon Apr 24, 2025
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.Add `buildMode`, `icuDataPath` and `engineRevision` interpolations fo…