Skip to content

[DisplayList] DlOpReceiver testing classes should use gmock #165336

Open

Description

@flar

There are a number of testing classes used to test sequences of DlOpReceiver calls that all use custom code to store expected clips, or save layers, or depth indications and then explicitly implement the interface to vet those values.

These classes should probably be replaced by a global gmock version of that interface.

See these sites for potential migration:

  • display_list_unittests.cc
    • SaveLayerExpector
    • SaveLayerBoundsExpector
    • DepthExpector
    • ClipExpector
  • performance_overlay_layer_unittests.cc
    • ImageSizeTextBlobInspector

Activity

  1. changed the title [-]DlOpReceiver testing classes should use gmock[/-] [+][DisplayList] DlOpReceiver testing classes should use gmock[/+] on Mar 17, 2025
  2. added
    in triagePresently being triaged by the triage team
    a: tests"flutter test", flutter_test, or one of our tests
    engineflutter/engine related. See also e: labels.
    c: proposalA detailed proposal for a change to Flutter
    and removed
    in triagePresently being triaged by the triage team
    on Mar 18, 2025
  3. added
    P3Issues that are less important to the Flutter project
    on Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projecta: tests"flutter test", flutter_test, or one of our testsc: proposalA detailed proposal for a change to Flutterengineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions