Repository navigation
experimental_ad_unit_widget_test.dart failures blocking Flutter into packages roll #165347
Description
I'm seeing consistent failures of https://github.com/flutter/packages/blob/main/packages/google_adsense/example/integration_test/experimental_ad_unit_widget_test.dart in the Flutter into packages roller:
Failure Details:
Failure in method: Responsive (with adFormat) ad units reflow flutter
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════
The following TestFailure was thrown running a test:
Expected: <137.0>
Actual: <1.0>
When the exception was thrown, this was the stack:
at module0.Error._throwWithCurrentStackTrace (http://localhost:7357/main.dart.wasm:wasm-function[792]:0xf433c)
at module0.fail (http://localhost:7357/main.dart.wasm:wasm-function[14984]:0x1eaa52)
at module0._expect (http://localhost:7357/main.dart.wasm:wasm-function[14974]:0x1ea8d6)
at module0.expect (http://localhost:7357/main.dart.wasm:wasm-function[14973]:0x1ea7da)
at module0.expect (http://localhost:7357/main.dart.wasm:wasm-function[14928]:0x1e9c7c)
at module0.main closure at file:///b/s/w/ir/x/w/packages/packages/google_adsense/example/integration_test/experimental_ad_unit_widget_test.dart:37:9 inner (http://localhost:7357/main.dart.wasm:wasm-function[28265]:0x30af9f)
at module0._awaitHelper closure at org-dartlang-sdk:///dart-sdk/lib/_internal/wasm/lib/async_patch.dart:95:5 (http://localhost:7357/main.dart.wasm:wasm-function[1715]:0x1027b0)
at module0.closure wrapper at org-dartlang-sdk:///dart-sdk/lib/_internal/wasm/lib/async_patch.dart:95:5 trampoline (http://localhost:7357/main.dart.wasm:wasm-function[1720]:0x10284a)
The test description was:
Responsive (with adFormat) ad units reflow flutter
═════════════════════════════════════════════════════════════════
Latest roll attempt: https://github.com/flutter/packages/pull/8886. Example failing build: https://ci.chromium.org/ui/p/flutter/builders/try/Linux_web%20web_platform_tests_wasm_shard_1%20master/722/overview.
Did some testing and notice it fails more consistently after #164748 than before.
Activity
Revert "[skwasm] Dynamic Threading (flutter#164748)"
Revert "[skwasm] Dynamic Threading (#164748)" (#165350)
stuartmorgan-g commentedon Mar 18, 2025
Looks like there was a revert. /cc @ditman (current gardener) to validate whether this is resolved in the roller.
eyebrowsoffire commentedon Mar 18, 2025
If we do determine that the revert fixed it, let's please leave this open for me to investigate this issue before relanding the skwasm dynamic threading stuff.
Use a more deterministic way of waiting for ad widgets to be ready. (#…
Use a more deterministic way of waiting for ad widgets to be ready. (f…
Reland "[skwasm] Dynamic Threading"
yjbanov commentedon Apr 2, 2025
The culprit was reverted, and the reland is landing with a fix. Closing.
Reland "[skwasm] Dynamic Threading" (#166454)
Reland "[skwasm] Dynamic Threading"
github-actions commentedon Apr 17, 2025
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.