Skip to content

Dialog.fullscreen should set a parentRoute.fullscreenDialog #165478

Closed
#167794
Closed
Dialog.fullscreen should set a parentRoute.fullscreenDialog#165478
#167794
Labels
P2Important issues not at the top of the work listc: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packagesteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team

Description

@feinstein
feinstein
opened on Mar 19, 2025

Use case

I am showing a dialog using the Dialog.fullscreen constructor, but when I do it and I have an AppBar inside the dialog, then the AppBar will show a BackButton and not a CloseButton.

This happens because the AppBar automatically selects it's button based on parentRoute.fullscreenDialog, which showDialog nor showGeneralDialog set to true, since they don't create a PageRoute but a RawDialogRoute that doesn't have this flag available.

Proposal

showDialog and it's variants like showGeneralDialog should have an optional parameter fullscreenDialog that can be forwarded (and added) to RawDialogRoute and DialogRoute, so the AppBar could automatically detect if it's current route is a full-screen one.

Activity

  1. maheshj01
    added
    in triagePresently being triaged by the triage team
    frameworkflutter/packages/flutter repository. See also f: labels.
    p: material_uimaterial_ui package in flutter/packages
    team-designOwned by Design Languages team
    c: new featureNothing broken; request for a new capability
    c: proposalA detailed proposal for a change to Flutter
    and removed
    in triagePresently being triaged by the triage team
    on Mar 19, 2025
  2. dkwingsmt
    added
    P2Important issues not at the top of the work list
    triaged-designTriaged by Design Languages team
    on Mar 27, 2025
  3. github-merge-queue
    added a commit that references this issue on May 21, 2025

    Feat: Add full screen dialog support for dialog routes (#167794)

    78df503
  4. auto-submit
    closed this as completedin #167794on May 21, 2025

  5. github-actions commented on Jun 4, 2025

    @github-actions
    github-actionsbot
    on Jun 4, 2025 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. github-actions
    locked as resolved and limited conversation to collaborators on Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packagesteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions