Repository navigation
[Proposal] Avoid profile build dependencies in configureCMakeDebug; introduce configureCMakeProfile for profile mode #166744
Description
We have a custom job per build mode attached to the the preDebugBuild, preProfileBuild and preReleaseBuild for the corresponding build modes. Since our upgrade from 3.27 to 3.29 we suddenly see that a flutter run for a debug build triggers the custom job both for the debug and profile build. After some debugging I found that configureCMakeDebug has a dependency on preProfileBuild which it doesn't had before. I bisected the code and found that #159756 introduced this behaviour. (#160205 fixes it and #160260 reintroduces it again). If the forceNdkDownload call is commented out the issue disappears.
I don't know if this is a Flutter specific issue, could also be Android.
Reproduce:
flutter create my_app
cd my_app/android
./gradlew --dry-run configureCMakeDebug
Activity
maheshj01 commentedon Apr 9, 2025
@middagj thanks for filing the issue, Could you please clarify what the expected output should be when running
./gradlew --dry-run configureCMakeDebugThis is what I see
flutter doctor -v
stable
middagj commentedon Apr 9, 2025
@maheshj01 thanks for the quick reply. I did some more digging. If you use the taskTree plugin, this is what you get
compare this to an empty Android project with the same config to force NDK download added:
gradleProject.android { externalNativeBuild { cmake { // Respect the existing configuration if it exists - the NDK will already be // downloaded in this case. path = flutterSdkRootPath + "/packages/flutter_tools/gradle/src/main/groovy/CMakeLists.txt" } } defaultConfig { externalNativeBuild { cmake { // CMake will print warnings when you try to build an empty project. // These arguments silence the warnings - our project is intentionally // empty. arguments("-Wno-dev", "--no-warn-unused-cli") } } } }then I get the following taskTree on
configureCMakeDebugNext to the
configureCMakeDebugthere is aconfigureCMakeRelWithDebInfowhich has a taskTree:So with Android there is a 1-1 mapping between
configureCMakeDebugtopreDebugBuildandconfigureCMakeRelWithDebInfotopreReleaseBuild.Flutter adds the
profilebuild mode and somehow thepreDebugBuilddependency gets swapped withpreProfileBuild(andpackJniLibsflutterBuildProfilelikewise) . The swapping is erroneous I believe. My expectation is that this does not happen.Note that even if the swapping is fixed, the added
profilebuild mode has no naturalconfigureCMaketask. This task is a dependency ofmergeDebugNativeLibs. So if theconfigureCMakeDebugonly depends onpreDebugBuild, the same problem arises whenmergeProfileNativeLibsis executed: then thepreDebugBuildis called which shouldn't. A better fix would probably when theprofilebuild mode is added to copy theconfigureCMakeDebugtoconfigureCMakeProfileand only change the dependencies, leaving the original dependencies ofconfigureCMakeDebuguntouched and letmergeProfileNativeLibsdepend onconfigureCMakeProfile.maheshj01 commentedon Apr 9, 2025
Thank you for the detailed clarification, I'm going to label this as a proposal for the same and for insights from the Android team for this behavior.
[-]Gradle task configureCMakeDebug depends on preProfileBuild since 3.29[/-][+][Proposal] Avoid profile build dependencies in configureCMakeDebug; introduce configureCMakeProfile for profile mode[/+]gmackall commentedon Apr 15, 2025
Interesting, thanks for the detailed report.
Recreating as you did with a blank Android project and using the taskTree plugin I see the same:
But if I add a profile build type to the Android project in the same way Flutter does:
I see the same behavior we are getting in Flutter:
Perhaps this is a bug in how the task names are created in the Android Gradle plugin? Or in how we are creating the build type? Need to dig into this further
gmackall commentedon Apr 15, 2025
I did a bit of inspection in to how AGP makes this name and
#167240
fixes the problem, I believe.
Looks like for our case they get the name from the cmake args, so this passes in the build type name for the (android)
BuildTypeto the cmake args, and also moves the forcing from before to after the creation of the profile build type.Set an additional CMake arg in `forceNdkDownload` to make the task na…
Set an additional CMake arg in `forceNdkDownload` to make the task na…
github-actions commentedon Apr 30, 2025
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.Set an additional CMake arg in `forceNdkDownload` to make the task na…