Initial release branch presubmit will *always* fail due to licensing check

@jtmcdole

In #166783, I started a new release branch.

One component of making a release branch is pinning to a specific Dart commit SHA:

However, that will always cause the Linux licensing (engine) check to fail, because it references the Dart SHA:

The license test can only be run on a Linux machine, which most Flutter engineers do not use day-to-day, so they either need to remember (and use) a Linux machine, or they need to push, wait for the engine to build and for the license test to run (wasting resources otherwise), and copy the resulting Signature: ... in order to make progress.

The easiest thing to do would be able to regenerate the licenses golden on a Mac. @jtmcdole mentioned it might work now?

/cc @reidbaker

We'll look at making this runnable on a Mac.

@gaaclarke

@gaaclarke Has graciously offered to help out here .

The easiest thing to do would be able to regenerate the licenses golden on a Mac

FWIW it's not that easy because the license checker is very slow. It takes over 10 minutes to execute. Most of that time is in regex and could be parallelized. It's a bit tricky to parallelize because of the OO design.

I would take 10 minutes executing locally (particularly if we could have progress updates) over having to run on CI for 30-60 minutes.

I don't know the exact time it takes locally. I haven't had the foresight to measure it exactly yet. It may be closer to 30 minutes.

note to self: example output from local run

License script got different results than expected for out/license_script_output/licenses_dart.
Please rerun the licenses script locally to verify that it is
correctly catching any new licenses for anything you may have
changed, and then update this file:
  flutter/sky/packages/sky_engine/LICENSE
For more information, see the script in:
  https://github.com/flutter/engine/tree/main/tools/licenses

--- flutter/ci/licenses_golden/licenses_dart	2025-04-14 09:58:03
+++ out/license_script_output/licenses_dart	2025-04-14 15:15:09
@@ -4859,12 +4859,12 @@
 Exhibit B - "Incompatible With Secondary Licenses" Notice
 ---------------------------------------------------------
 
   This Source Code Form is "Incompatible With Secondary Licenses", as
   defined by the Mozilla Public License, v. 2.0.
 
-You may obtain a copy of this library's Source Code Form from: https://dart.googlesource.com/sdk/+/4293d50dd30d5469fac05af7470148977327bbe8
+You may obtain a copy of this library's Source Code Form from: https://dart.googlesource.com/sdk/+/87965ab4864e444c521023820eb06e569d007059
 /third_party/fallback_root_certificates/

87965ab4864e444c521023820eb06e569d007059 comes from cd third_party/dart; git rev-parse HEAD

license checker: ignore git sha in dart license (#167153)

license checker: ignore git sha in dart license (flutter#167153)

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

license checker: ignore git sha in dart license (flutter#167153)

Navigation Menu

Repository navigation

Initial release branch presubmit will always fail due to licensing check #166807

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Initial release branch presubmit will *always* fail due to licensing check #166807

Description

Activity

matanlurey commented on Apr 14, 2025

matanlurey commented on Apr 14, 2025

gaaclarke commented on Apr 14, 2025

matanlurey commented on Apr 14, 2025

gaaclarke commented on Apr 14, 2025

gaaclarke commented on Apr 14, 2025

github-actions commented on Apr 29, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Initial release branch presubmit will always fail due to licensing check #166807