Skip to content

ModalRoute lacks aspect for opaque property #167058

Closed
#167324
Closed
ModalRoute lacks aspect for opaque property#167058
#167324
Labels
c: proposalA detailed proposal for a change to Flutterf: routesNavigator, Router, and related APIs.frameworkflutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionteam-frameworkOwned by Framework team

Description

@navaronbracke
navaronbracke
opened on Apr 13, 2025

Use case

Developers that want to use more aspects of ModalRoute, such as opaque

Proposal

While the ModalRoute is an InheritedModel, we cannot depend on the opaque property through an aspect.

We should probably audit the missing aspects as a whole.

Stuff that should probably be an aspect: (there are probably more that can be added, but I'm not sure about those)

Discovered while reviewing #167032

Activity

  1. danagbemava-nc
    added
    in triagePresently being triaged by the triage team
    frameworkflutter/packages/flutter repository. See also f: labels.
    f: routesNavigator, Router, and related APIs.
    c: proposalA detailed proposal for a change to Flutter
    team-frameworkOwned by Framework team
    and removed
    in triagePresently being triaged by the triage team
    on Apr 14, 2025
  2. github-merge-queue
    added a commit that references this issue on May 29, 2025

    Feat: Add opaque, isActive, isFirst, popDisposition aspects for Modal…

    df29894
  3. auto-submit
    closed this as completedin #167324on May 29, 2025
  4. salemiranloye
    added a commit that references this issue on May 29, 2025

    Feat: Add opaque, isActive, isFirst, popDisposition aspects for Modal…

    3ec43c7
  5. danagbemava-nc
    added
    r: fixedIssue is closed as already fixed in a newer version
    on May 30, 2025

  6. github-actions commented on Jun 13, 2025

    @github-actions
    github-actionsbot
    on Jun 13, 2025 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. github-actions
    locked as resolved and limited conversation to collaborators on Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c: proposalA detailed proposal for a change to Flutterf: routesNavigator, Router, and related APIs.frameworkflutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionteam-frameworkOwned by Framework team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions