Skip to content

[web:a11y] reconsider applying role="dialog" to arbitrary routes #168247

Closed
Closed
[web:a11y] reconsider applying role="dialog" to arbitrary routes#168247
Assignees
flutter-zl
Labels
P2Important issues not at the top of the work lista: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)customer: castawayfyi-accessibilityFor the attention of Framework Accessibility teamplatform-webWeb applications specificallyteam-webOwned by Web platform teamtriaged-webTriaged by Web platform team

Description

@yjbanov
yjbanov
opened on May 2, 2025

Currently, the web engine applies role="dialog" as a default fallback for all routes. This logic predates SemanticsRole.dialog and SemanticsRole.alertDialog. Because the engine couldn't tell if a route is a dialog it used the dialog role just in case. This seems no longer necessary now that we have the formal roles, so perhaps it is time to remove this fallback. Basically, the proposal is to remove this line:

flutter/engine/src/flutter/lib/web_ui/lib/src/engine/semantics/route.dart

Line 108 in 7448418

setAriaRole('dialog');

Activity

  1. yjbanov
    added
    a: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)
    platform-webWeb applications specifically
    P2Important issues not at the top of the work list
    customer: castaway
    team-webOwned by Web platform team
    triaged-webTriaged by Web platform team
    fyi-accessibilityFor the attention of Framework Accessibility team
    on May 2, 2025
  2. flutter-zl
    self-assigned this
    on May 2, 2025
  3. github-merge-queue
    added a commit that references this issue on May 8, 2025

    Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute cl…

    76747c0

  4. flutter-zl commented on May 12, 2025

    @flutter-zl
    flutter-zl
    on May 12, 2025
    Contributor

    Fixed in #168345. Feel free to reopen if issue persists.

  5. flutter-zl
    closed this as completedon May 12, 2025

  6. github-actions commented on May 26, 2025

    @github-actions
    github-actionsbot
    on May 26, 2025 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. github-actions
    locked as resolved and limited conversation to collaborators on May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work lista: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)customer: castawayfyi-accessibilityFor the attention of Framework Accessibility teamplatform-webWeb applications specificallyteam-webOwned by Web platform teamtriaged-webTriaged by Web platform team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions