Skip to content

Add enabled_branches: [ "flutter-\d+\.\d+-candidate\.\d+" ] to scheduler: release targets #168745

Description

@matanlurey

The following line was updated to recipes/release/release_builder.py in 2d1e37419fd94e89c0dbbb2a0a86b9e337c48ddc:

def ShouldRun(api, git_ref, target, release_branch):
  """Validates if a target should run based on platform, channel and repo."""
  # Enabled for current branch
  enabled_branches = target.get('enabled_branches', [])
-  if enabled_branches:
+  if enabled_branches and target.get('scheduler') != 'release':

This was to work around some issue poorly explained in #128459.

CL: https://flutter-review.googlesource.com/c/recipes/+/45564/2/recipes/release/release_builder.py#45.

I believe we could remove this line by adding the following to .ci.yaml targets:

  - name: Linux flutter_packaging
    recipe: packaging/packaging
    timeout: 60
    scheduler: release
    bringup: true # https://github.com/flutter/flutter/issues/126286
    enabled_branches:
      - beta
      - stable
+     - flutter-\d+\.\d+-candidate\.\d+
    properties:
      task_name: flutter_packaging
      tags: >
        ["framework", "hostonly", "shard", "linux"]
    drone_dimensions:
      - os=Linux

Note that this change would have to be cherrypicked to active release branches as well.

Activity

  1. added
    team-infraOwned by Infrastructure team
    P2Important issues not at the top of the work list
    on May 13, 2025
  2. added theissue type on May 13, 2025
  3. self-assigned this
    on May 13, 2025
  4. github-actions commented on May 28, 2025

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  5. locked as resolved and limited conversation to collaborators on May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.infra: recipesIssues with flutter/recipesteam-infraOwned by Infrastructure team

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions