Repository navigation
Chips Demo in Gallery not accessible #16964
Description
For the chips with the delete button you can only focus on the delete button. You can't focus the chip text.
The focus frame around the different titles of this page are also to big.
/cc @gspencergoog
Activity
jonahwilliams commentedon Apr 26, 2018
In another app with chips I noticed that the entire chip is tappable instead of just the X
goderbauer commentedon Apr 26, 2018
@jonahwilliams was that a Flutter app?
gspencergoog commentedon Apr 26, 2018
In some legacy apps (before the other kinds of Chip were invented), they wrap a GestureDetector around the entire Chip, so it could be one of those.
jonahwilliams commentedon Jul 11, 2018
I've improved the tap handling of the demo - however we should consider updating the demo to not use the "X" icons.
gspencergoog commentedon Jul 11, 2018
How would that work exactly? They need to have delete buttons for the demo to function (part of the demo is removing things and seeing the available actions change). Or do you just mean to literally use a different icon for the delete icon?
jonahwilliams commentedon Jul 11, 2018
From the internal guidelines - chips on touch devices should not show the secondary trailing affordance by default. I think it is probably okay since it is really just a demo of the capabilities.
gspencergoog commentedon Jul 11, 2018
I think they just mean that not all chips should have delete buttons. I think they generally want there to be a "chip editing mode" which you go into in order to delete the chips, but that normally they're not visible. Once we have a "ChipField" widget that lets you enter chips and text together, then that will have such a mode, and the delete buttons on the embedded chips will only appear when it's in that mode. We can add it to the demo then.
jonahwilliams commentedon Sep 7, 2018
This is mostly done, but I have not implemented the semantics for chips with 2 or more actions since they are not supported for accessibility on mobile devices
clocksmith commentedon Jan 13, 2020
The material chips on android have separate semantic nodes for the delete button on all chips (they also show a demo of a chip that is both selectable and deletable)
clocksmith commentedon Jan 13, 2020
Closing since the gallery works as expected. But opened #48739 for better behavior when there is a delete option
github-actions commentedon Aug 15, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.