Skip to content

[Impeller] eliminate PathReceiver.PathEnd #169719

Closed

Description

@flar

There is only one path receiver that uses this method and it is only ever used from within the utility helper methods within one class (PathTessellator). In all other classes it is ignored because they don't care about knowing when the path is done. Additionally there are cases where multiple PathSource objects are used together to compose a longer path and so while each might think the "path is done" (i.e. send PathEnd()), they would not be correct in those cases.

Rather than make this the responsibility of all PathSource objects to send this final method call, which is ignored in most cases, we should just have the one case where "final processing" is a necessary requirement define that the process of feeding that one object includes letting it know when all of the path segments are done.

Activity

  1. self-assigned this
    on May 30, 2025
  2. github-actions commented on Jun 28, 2025

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  3. locked as resolved and limited conversation to collaborators on Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions