Repository navigation
Consider adding a presubmit check for updates to engine.version #170012
Description
For releases, we often need to update the bin/internal/engine.version file to a newest SHA referencing a commit that includes all the changes (including relevant cherry-picks) that we want to include in the release. However, this SHA can only reference a change that actually includes engine changes. We should consider adding a presubmit test that (1) checks if the SHA that we choose includes an engine change and if not, (2) warns if an older SHA should be used to reference a change with engine modifications/if it doesn't need to modified at all (I assume this is a case we could fall into for hotfix releases but I may be wrong).
CC @matanlurey as this was inspired by my mistakes in #169952, fixed by #170005
Activity
matanlurey commentedon Jun 4, 2025
This seems really reasonable.
The hard part is, of course - where does this check live, and what triggers it?
My thought:
Linux analyzeseries of testsengine.versionI will take a look!
Release validation: Check `bin/internal/engine.version` in presubmit (#…
Squashed commit of the following:
github-actions commentedon Jun 19, 2025
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.Release validation: Check `bin/internal/engine.version` in presubmit …