Repository navigation
Verify that flutter upgrade could handle a "new" release with an older commit #170679
Description
This is a postmortem action item to help decide how we'd fix a "bad release" in the future.
Imagine that we had pushed the contents of 3.32.2 as 3.32.4 to (temporarily) fix the broken release, 3.32.3.
We are not sure if we had done this, if it would have worked.
We could try experimenting, i.e. with a beta release, or otherwise perhaps try to mock/stub this happening locally (i.e. it's just git).
@jtmcdole Did you want to try this? If not let's assign it to @bkonyi - I have too many AIs (#170547, #170561, #170568) on my plate at the moment to take this up.
Activity
jtmcdole commentedon Jun 16, 2025
@bkonyi - after the postmortem on the 3.32.3 release, we have a PM AI to verify that the Flutter Tool would have "done the right thing" if we had pushed a new release with an old gitsha.
matanlurey commentedon Jun 23, 2025
Ping @bkonyi is this something you could look at fairly soon?
This is a postmortem action item, and is important for the release team to know if we ran into a bad build, we could make a recovery release (release an older commit as the latest tag, and the
fluttertool would still function as expected).bkonyi commentedon Jun 24, 2025
Yup, I'll take a look sometime today.
bkonyi commentedon Jun 24, 2025
From a quick scan, I don't see any reason why the tool wouldn't be able to handle a new release that points to an older commit as long as we tag it with a more recent version. I'll see if I can write a test to try and mimic the scenario.
bkonyi commentedon Jun 24, 2025
Ah, it looks like the upgrade check first retrieves the latest revision for the channel and checks for tags based on the revision. That means if we have a broken release tagged
a.b.cand we create a new release with taga.b.c+1that points to an older revision, the tool won't detecta.b.c+1as a newer release.To support new releases that are based on a framework revision older than the current release revision, we'd need to rework our upgrade logic to rely on the tag version strings to detect if there's a new Flutter version available.
matanlurey commentedon Jun 25, 2025
As we discussed in triage, @bkonyi is going to come up with an estimate of:
... and then we'll meetup and decide if it's worth prioritizing.
[ Tool ] Support upgrading to a new Flutter version pointing to the s…
[ Tool ] Support upgrading to a new Flutter version pointing to the s…
[ Tool ] Support upgrading to a new Flutter version pointing to the s…
[ Tool ] Support upgrading to a new Flutter version pointing to the s…
github-actions commentedon Jul 22, 2025
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.[ Tool ] Support upgrading to a new Flutter version pointing to the s…
[ Tool ] Support upgrading to a new Flutter version pointing to the s…
[ Tool ] Support upgrading to a new Flutter version pointing to the s…
[ Tool ] Support upgrading to a new Flutter version pointing to the s…