24 hour time format resets to default after full restart #17154

Activity

1. slightfoot commented on May 1, 2018

   

   slightfoot

   on May 1, 2018

   Last edited by slightfoot

   Member

   More actions

   This came up from a conversation on the Flutter Study Group linked here: https://flutterstudygroup.slack.com/archives/CACLB2TGC/p1525186221000266

   Highlights are below.
   Looks like the dart code which updates the ui.window by hooks.dart is not being called after hot-reload or full-restart. Looking into the details from the FlutterView side the "user settings" (text scale and 24hr format) only get updated on the kSettingsChannel on creation of the Activity and onConfigurationChanged. Which does not account for hot-reload and/or full-restart.

   So this is an issue more about persisting the current settings across the Isolate reload. Looking into it further it seem's RuntimeController::FlushRuntimeStateToIsolate does not call SetUserSettingsData which is the only part I can see where it might be the cause of the bug.
2. zoechi

   added

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   on Jul 26, 2018
3. zoechi

   added this to the Stretch GoalsThis milestone has been deleted milestone on Jul 26, 2018
4. goderbauer

   added

   t: hot reloadReloading code during "flutter run"Reloading code during "flutter run"

   engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.

   a: internationalizationSupporting other languages or locales. (aka i18n)Supporting other languages or locales. (aka i18n)

   on Dec 28, 2018
5. jmagman

   added

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   on Sep 16, 2019
6. Hixie

   modified the milestones: Stretch GoalsThis milestone has been deleted, New Stretch GoalsThis milestone has been deleted on Jan 7, 2020
7. gaaclarke

   added 2 commits that reference this issue on Mar 24, 2020

   flutter-team-archive/engine@2d42c74...d7ad50c

   ...

   7782a15

   flutter-team-archive/engine@2d42c74...d7ad50c

   ...

   ea25ed6
8. kf6gpe

   added

   P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter project

   on May 29, 2020
9. kf6gpe

   modified the milestone: Stretch GoalsThis milestone has been deleted on Jun 1, 2020
10. Hixie

    removed this from the [DEPRECATED] Stretch GoalsThis milestone has been deleted milestone on Jun 16, 2020
11. Hixie

    removed this from the -This milestone has been deleted milestone on Aug 17, 2020
12. TahaTesser

    added

    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter respondsThe Flutter team cannot make further progress on this issue until the original reporter responds

    on Aug 26, 2020
13. TahaTesser commented on Sep 7, 2020

    

    TahaTesser

    on Sep 7, 2020

    Contributor

    More actions

    I see there's an open issue addressing the case you described. #13703
    Please follow up on that issue, I'm closing the current one as a duplicate.
    If you disagree, please write in the comments and I will reopen it.
    Thank you
14. TahaTesser

    closed this as completedon Sep 7, 2020
15. pedromassangocode

    removed

    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter respondsThe Flutter team cannot make further progress on this issue until the original reporter responds

    on Dec 30, 2020
16. github-actions commented on Aug 7, 2021

    

    github-actionsbot

    on Aug 7, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
17. github-actions

    locked as resolved and limited conversation to collaborators on Aug 7, 2021