Last item in the SliverMainAxisGroup list, performs an upward animation when it is time to change the PinnedHeaderSliver (Flutter 3.32) #173274
Copy link
Copy link
Closed
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: regressionIt was better in the past than it is nowIt was better in the past than it is nowf: scrollingViewports, list views, slivers, etc.Viewports, list views, slivers, etc.found in release: 3.32Found to occur in 3.32Found to occur in 3.32found in release: 3.33Found to occur in 3.33Found to occur in 3.33frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onp: material_uimaterial_ui package in flutter/packagesmaterial_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-frameworkOwned by Framework teamOwned by Framework teamtriaged-frameworkTriaged by Framework teamTriaged by Framework team
Description
Activity
- addedin triagePresently being triaged by the triage teamPresently being triaged by the triage team
on Aug 5, 2025 Thanks for the detailed report. Appreciate it @danielparsan! Seeing the same behaviour with latest SDK versions with provided code sample and steps. however, it's not reproducible on
3.29.3, so marking this as a regression.stable : 3.32.8 master : 3.33.0-1.0.pre-1278Bisected to #163528
Bisect Logs
tirthpatel@Tirths-MacBook-Pro au5 % cd ~/Development/flutter_stable_latest/flutter tirthpatel@Tirths-MacBook-Pro flutter % git bisect start status: waiting for both good and bad commits tirthpatel@Tirths-MacBook-Pro flutter % git bisect bad status: waiting for good commit(s), bad commit known tirthpatel@Tirths-MacBook-Pro flutter % git bisect good ea121f8 Bisecting: a merge base must be tested [010c8a806bccad64ab9972286b85dd24ca98441f] Revert "Autocomplete Options Width" (#161666) tirthpatel@Tirths-MacBook-Pro flutter % git bisect good Bisecting: 658 revisions left to test after this (roughly 9 steps) [07503bbc82a7372a6a685e5b5d1406d139b8353c] [macOS] Prepare FlutterKeyboardManager for multi-view (#163962) tirthpatel@Tirths-MacBook-Pro flutter % git bisect bad Bisecting: 328 revisions left to test after this (roughly 8 steps) [9438fd44712be71b33c9c6f325110be268dbec47] [Android] add runtime flag to determine if HCPP is supported. (#163004) tirthpatel@Tirths-MacBook-Pro flutter % git bisect good Bisecting: 164 revisions left to test after this (roughly 7 steps) [3decd62f3af408bade757aa091101b4bf1b90a90] Revert "Create g3_bug.yml" (#163757) tirthpatel@Tirths-MacBook-Pro flutter % git bisect good Bisecting: 82 revisions left to test after this (roughly 6 steps) [99e1a0652c2a2d0b692d9d02e0f4263e1af1a3d6] Fix extra numbers showing up when enabling VoiceControl (#163593) tirthpatel@Tirths-MacBook-Pro flutter % git bisect bad Bisecting: 40 revisions left to test after this (roughly 5 steps) [4973143100f32bbe4c92bce45ffbf0abc896096f] Roll Skia from 4bee660601de to 72f949950adb (1 revision) (#163948) tirthpatel@Tirths-MacBook-Pro flutter % git bisect good Bisecting: 20 revisions left to test after this (roughly 4 steps) [271cb8c8c5c7c023e35fa982e9a1d32dfaccdf68] Add BorderRadiusGeometry to Divider Widget for Customisable Border Radius (#163414) tirthpatel@Tirths-MacBook-Pro flutter % git bisect bad Bisecting: 9 revisions left to test after this (roughly 3 steps) [1e2583eff25200b10f01d1fc2d13e7936fba57d2] [ui] Fix ImageFilter.shader equality to consider uniform values. (#163348) tirthpatel@Tirths-MacBook-Pro flutter % git bisect good Bisecting: 4 revisions left to test after this (roughly 2 steps) [a4a5a33cfad5e11461d192f76edce6c220de2bdd] Roll .ci.yaml changes into the LUCI configuration only when the master branch is updated (#163897) tirthpatel@Tirths-MacBook-Pro flutter % git bisect good Bisecting: 2 revisions left to test after this (roughly 1 step) [ebc7d244d365a8bb5ea3b7f1d8c5dc87107ab44f] Roll Skia from 994168b1ba10 to a141a3ceef87 (1 revision) (#164023) tirthpatel@Tirths-MacBook-Pro flutter % git bisect good Bisecting: 0 revisions left to test after this (roughly 1 step) [4e39d13a6f67fa04a9dc424cd20663da9b81301b] SliverMainAxisGroup multiple PinnedHeaderSliver children (#163528) tirthpatel@Tirths-MacBook-Pro flutter % git bisect bad Bisecting: 0 revisions left to test after this (roughly 0 steps) [7535cb10bcd4565032f68e1b975875f7686a955e] Move `AndroidRenderingApi` from `common` to `shell/platform/android` (#163796) tirthpatel@Tirths-MacBook-Pro flutter % git bisect good 4e39d13a6f67fa04a9dc424cd20663da9b81301b is the first bad commit commit 4e39d13a6f67fa04a9dc424cd20663da9b81301b Author: yim <[email protected]> Date: Tue Feb 25 13:53:03 2025 +0800 SliverMainAxisGroup multiple PinnedHeaderSliver children (#163528) Fixes: #155758 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md .../flutter/lib/src/rendering/sliver_group.dart | 96 ++++++++++++---------- .../test/widgets/sliver_main_axis_group_test.dart | 84 +++++++++++++++++++ 2 files changed, 135 insertions(+), 45 deletions(-) tirthpatel@Tirths-MacBook-Pro flutter %
3.29.3 3.32.8 & 3.33.0-1.0.pre-1278 Screen.Recording.2025-08-05.at.7.03.55.PM.mov
Screen.Recording.2025-08-05.at.7.05.01.PM.mov
Reacted by danielparsan- addedfound in release: 3.32Found to occur in 3.32Found to occur in 3.32found in release: 3.33Found to occur in 3.33Found to occur in 3.33frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.f: scrollingViewports, list views, slivers, etc.Viewports, list views, slivers, etc.p: material_uimaterial_ui package in flutter/packagesmaterial_ui package in flutter/packagesteam-frameworkOwned by Framework teamOwned by Framework teamc: regressionIt was better in the past than it is nowIt was better in the past than it is nowhas reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onand removedin triagePresently being triaged by the triage teamPresently being triaged by the triage team
on Aug 5, 2025 - addedP1High-priority issues at the top of the work listHigh-priority issues at the top of the work listand removedc: regressionIt was better in the past than it is nowIt was better in the past than it is nowf: scrollingViewports, list views, slivers, etc.Viewports, list views, slivers, etc.P1High-priority issues at the top of the work listHigh-priority issues at the top of the work list
on Aug 5, 2025 5 remaining items
- addedc: regressionIt was better in the past than it is nowIt was better in the past than it is nowfound in release: 3.32Found to occur in 3.32Found to occur in 3.32found in release: 3.33Found to occur in 3.33Found to occur in 3.33f: scrollingViewports, list views, slivers, etc.Viewports, list views, slivers, etc.
on Aug 6, 2025 Thanks for confirming that, @tirth-patel-nc . I really appreciate you checking it out, and I also thank all the members who are working together to resolve this issue.
Reacted by Tirth Patel- added a commit that references this issue
on Aug 12, 2025 - addedr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version
on Aug 12, 2025 - added a commit that references this issue
on Aug 19, 2025 This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Aug 26, 2025 - added a commit that references this issue
on Sep 18, 2025 - added a commit that references this issue
on Sep 22, 2025 - added a commit that references this issue
on Nov 21, 2025
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: regressionIt was better in the past than it is nowIt was better in the past than it is nowf: scrollingViewports, list views, slivers, etc.Viewports, list views, slivers, etc.found in release: 3.32Found to occur in 3.32Found to occur in 3.32found in release: 3.33Found to occur in 3.33Found to occur in 3.33frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onp: material_uimaterial_ui package in flutter/packagesmaterial_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-frameworkOwned by Framework teamOwned by Framework teamtriaged-frameworkTriaged by Framework teamTriaged by Framework team
Steps to reproduce
✅ Note: This issue only occurs on Flutter 3.32+. It worked correctly in Flutter 3.29.
Expected results
When scrolling a long list grouped with
SliverMainAxisGroupandPinnedHeaderSliver, the pinned header should remain fixed at the top until the next header scrolls in and replaces it.The last list item should not push the header early. The header should only be replaced when the scroll reaches the next header.
Actual results
In Flutter 3.32, using
SliverMainAxisGroupwithPinnedHeaderSlivercauses the header to be pushed too early when reaching the last item of the list.This behavior did not happen in Flutter 3.29, where the sticky header was behaving as expected.
Code sample
Code sample
Screenshots or Video
Screenshots / Video demonstration
https://drive.google.com/file/d/1TsqpM5gKFeodYk1LvUpmjjnqElmZGnop/view?usp=sharing
Logs
Flutter Doctor output
Doctor output