CupertinoSheet example broken state with programmatic pop

@MitchellGoodwin

The "Go Back" button in the cupertino_sheet.1.dart example leaves the app in a broken state.

Steps to reproduce

Run the example in cupertino_sheet.1.dart.
Open the bottom sheet.
Press "Go Back".

Expected results

The bottom sheet closes fully.

Actual results

The bottom sheet disappears, but the underlying route does not animate. The app is frozen and can't be interacted with.

Screen.Recording.2025-09-15.at.3.46.50.PM.mov

FYI @MitchellGoodwin

@justinmc

@justinmc thanks for the report. Most likely this is dupe of #171878 (comment). Labelling it for team's tracking.

@justinmc

Hi @justinmc @MitchellGoodwin, I've taken a look at the source code and have some feedback. We have a PopScope widget that closes the sheet when the user attempts to pop the last page.

flutter/packages/flutter/lib/src/cupertino/sheet.dart

Lines 179 to 188 in 7ade3f3

    
           return PopScope( 
        
             canPop: false, 
        
             onPopInvokedWithResult: (bool didPop, Object? result) { 
        
               if (didPop) { 
        
                 return; 
        
               } 
        
               Navigator.of(context, rootNavigator: true).pop(result); 
        
             }, 
        
             child: effectivePageBuilder!(context), 
        
           );

However, this works only when the back button is used, as in that case didPop will be false. When we use Navigator.of(context).pop(), the route is getting popped, and didPop is true. If I remove the check for didPop, we end up with a weird UI:

bad_example.mov

For now, I don't know a way to prevent the route pop after Navigator.of(context).pop() call.

What I suggest is updating the example app. There is no canPop() check before calling pop(). You may similarly break any app by simply calling Navigator.of(context).pop() while you are on the initial route.

To prevent the issue, we can add an explicit canPop check like the following:

CupertinoButton.filled(
  onPressed: () {
    final navigator = Navigator.of(context);
    if (navigator.canPop()) {
      navigator.pop();
    } else {
      CupertinoSheetRoute.popSheet(context);
    }
  },
  child: const Text('Go Back'),
),

example.mov

What do you think?

For now, I don't know a way to prevent the route pop after Navigator.of(context).pop() call.

What I suggest is updating the example app. There is no canPop() check before calling pop(). You may similarly break any app by simply calling Navigator.of(context).pop() while you are on the initial route.

I agree that it's simpler to update the example app. But I think you can get the same result by just replacing navigator.pop() with navigator.maybePop().

For now, I don't know a way to prevent the route pop after Navigator.of(context).pop() call.

What I suggest is updating the example app. There is no canPop() check before calling pop(). You may similarly break any app by simply calling Navigator.of(context).pop() while you are on the initial route.

I agree that it's simpler to update the example app. But I think you can get the same result by just replacing navigator.pop() with navigator.maybePop().

We could definitely use maybePop to omit popping the initial page, but then the sheet will remain open, and tapping on Go Back will have no effect. Or may I miss something?

The sheet will close. maybePop will hit PopScope with a didPop of false.

The sheet will close. maybePop will hit PopScope with a didPop of false.

Indeed, thanks a lot for the explanation! I was always thinking that maybePop just checks canPop and then calls pop.

@ksokolovskyi

@ksokolovskyi you're changing this, or can i go ahead and change?

@rkishan516

@rkishan516, if you are ready to work on this issue, feel free to take it. Thanks!

Sure, let me make initial change then.

fix: cupertino sheet broken example with programatic pop (#175709)

fix: cupertino sheet broken example with programatic pop (flutter#175709

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

fix: cupertino sheet broken example with programatic pop (flutter#175709

Navigation Menu

Repository navigation

CupertinoSheet example broken state with programmatic pop #175390

Steps to reproduce

Expected results

Actual results

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	return PopScope(
	canPop: false,
	onPopInvokedWithResult: (bool didPop, Object? result) {
	if (didPop) {
	return;
	}
	Navigator.of(context, rootNavigator: true).pop(result);
	},
	child: effectivePageBuilder!(context),
	);

CupertinoSheet example broken state with programmatic pop #175390

Description

Steps to reproduce

Expected results

Actual results

Activity

tirth-patel-nc commented on Sep 16, 2025

ksokolovskyi commented on Sep 19, 2025

MitchellGoodwin commented on Sep 19, 2025

ksokolovskyi commented on Sep 19, 2025

MitchellGoodwin commented on Sep 19, 2025

ksokolovskyi commented on Sep 19, 2025

rkishan516 commented on Sep 21, 2025

ksokolovskyi commented on Sep 21, 2025

rkishan516 commented on Sep 21, 2025

github-actions commented on Oct 8, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions