Skip to content

autoroller script doesn't update flutter DEPS #176472

Description

@aam

Skia autoroller no longer runs create_updated_flutter_deps.py - we said that skia autoroller can rely on flutter's own script .autoroller-preupload.sh script (https://g-issues.skia.org/issues/433551375#comment14) for custom steps during the roll.

But that preupload script doesn't invoke create_updated_flutter_deps.py neither. As a result DEPS in flutter has not been updated with dart rolls, is out of sync with what dart sdk is building against.

cc @gaaclarke

Activity

  1. gaaclarke commented on Oct 3, 2025

    @gaaclarke
    Member

    @aam we can just run create_updated_flutter_deps.py in the .autoroller-preupload.sh script, right?

  2. aam commented on Oct 3, 2025

    @aam
    MemberAuthor

    @aam we can just run create_updated_flutter_deps.py in the .autoroller-preupload.sh script, right?

    Right.
    Followed by another gcient sync though.

  3. gaaclarke commented on Oct 3, 2025

    @gaaclarke
    Member

    Followed by another gcient sync though.

    Are you sure we want to do that? Wouldn't that just be slowing down the script and that check happens later downstream?

  4. aam commented on Oct 3, 2025

    @aam
    MemberAuthor

    Followed by another gcient sync though.

    Are you sure we want to do that? Wouldn't that just be slowing down the script and that check happens later downstream?

    Replied there: #176485 (comment)

  5. github-actions commented on Oct 17, 2025

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    team-infraOwned by Infrastructure team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions