Skip to content

package:web_benchmarks needs to be updated for unified skwasm/canvaskit renderers #177057

Closed
flutter/packages
#10236
Closed
package:web_benchmarks needs to be updated for unified skwasm/canvaskit renderers#177057
flutter/packages
#10236
Assignees
mdebbar
Labels
P1High-priority issues at the top of the work listc: proposalA detailed proposal for a change to Fluttere: wasmIssues related to the wasm build of Flutter Web.p: web_benchmarksflutter/packages web_benchmarkspackageflutter/packages repository. See also p: labels.platform-webWeb applications specificallyr: fixedIssue is closed as already fixed in a newer versionteam-webOwned by Web platform teamtriaged-webTriaged by Web platform team

Description

@elliette
elliette
opened on Oct 15, 2025

Now that the skwasm and canvaskit renderers emit the same frame events (see #175392), the expectedBenchmarkMetrics method here [1] no longer returns the expected events. They are now be the same for both skwasm and canvaskit.

To handle this, I suggest making useWasm an optional named parameter instead of required.

[1] https://github.com/flutter/packages/blob/1c0be204c45eea42927eb6005bb45f16a8fffb07/packages/web_benchmarks/lib/src/metrics.dart#L152-L155

(Note: This was noticed because the DevTools benchmark tests to began failing, see flutter/devtools#9456)

Activity

  1. elliette
    added
    p: web_benchmarksflutter/packages web_benchmarks
    on Oct 15, 2025
  2. tirth-patel-nc
    added
    in triagePresently being triaged by the triage team
    platform-webWeb applications specifically
    c: proposalA detailed proposal for a change to Flutter
    team-webOwned by Web platform team
    packageflutter/packages repository. See also p: labels.
    e: wasmIssues related to the wasm build of Flutter Web.
    and removed
    in triagePresently being triaged by the triage team
    on Oct 16, 2025
  3. mdebbar
    added
    P1High-priority issues at the top of the work list
    triaged-webTriaged by Web platform team
    on Oct 16, 2025
  4. mdebbar
    self-assigned this
    on Oct 16, 2025
  5. auto-submit
    closed this as completedin packages#10236on Nov 14, 2025
  6. jesswrd
    added a commit that references this issue on Nov 14, 2025

    [web_benchmarks] Report correct expected metrics for wasm (flutter#10236

    952418d
  7. tirth-patel-nc
    added
    r: fixedIssue is closed as already fixed in a newer version
    on Nov 14, 2025

  8. github-actions commented on Nov 28, 2025

    @github-actions
    github-actionsbot
    on Nov 28, 2025 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. github-actions
    locked as resolved and limited conversation to collaborators on Nov 28, 2025
  10. creatorpiyush
    added a commit that references this issue on Jun 10, 2026

    [web_benchmarks] Report correct expected metrics for wasm (flutter#10236

    340b14e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: proposalA detailed proposal for a change to Fluttere: wasmIssues related to the wasm build of Flutter Web.p: web_benchmarksflutter/packages web_benchmarkspackageflutter/packages repository. See also p: labels.platform-webWeb applications specificallyr: fixedIssue is closed as already fixed in a newer versionteam-webOwned by Web platform teamtriaged-webTriaged by Web platform team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions