Skip to content

Impeller compilation fails with Clang 21.1.0+ #178681

Closed

Description

@planetmarshall

Steps to reproduce

  1. Compile the engine sources (specifically Impeller) with Clang 21

Expected results

The engine successfully compiles

Actual results

Compilation fails with
../../flutter/impeller/renderer/vertex_descriptor.h:31:11: error: virtual method '~VertexDescriptor' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier

unnecessary-virtual-specifier was added in Clang 21.1.0

Code sample

N/A

Screenshots or Video

Screenshots / Video demonstration

[Upload media here]

Logs

Logs
[Paste your logs here]

Flutter Doctor output

N/a

Activity

  1. added
    in triagePresently being triaged by the triage team
    e: impellerImpeller rendering backend issues and features requests
    engineflutter/engine related. See also e: labels.
    and removed
    in triagePresently being triaged by the triage team
    on Nov 18, 2025
  2. chinmaygarde commented on Nov 24, 2025

    @chinmaygarde
    Contributor

    Thanks! This should help us stay ahead of issues with the next clang roll.

  3. added a commit that references this issue on Dec 15, 2025
    11022f4
  4. github-actions commented on Dec 29, 2025

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  5. locked as resolved and limited conversation to collaborators on Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High-priority issues at the top of the work liste: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine teamwaiting for PR to land (fixed)A fix is in flight

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions