[go_router] pop() not working when both top-level 'onEnter' and 'redirect' are async and the route have onExit callback #180002

Activity

1. darshankawar

   added

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   on Dec 18, 2025
2. darshankawar commented on Dec 18, 2025

   

   darshankawar

   on Dec 18, 2025

   Member

   More actions

   Thanks for the detailed report. Seeing the same behavior as reported with latest sdk versions.

   [ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception: Bad state: Future already completed

   This could be similar / related to #160696

   stable: 3.38.4
   master: 3.40.0-1.0.pre-192
   
3. darshankawar

   added

   p: go_routerThe go_router packageThe go_router package

   packageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.

   has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work on

   found in release: 3.38Found to occur in 3.38Found to occur in 3.38

   found in release: 3.40Found to occur in 3.40Found to occur in 3.40

   team-frameworkOwned by Framework teamOwned by Framework team

   and removed

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   on Dec 18, 2025
4. justinmc

   added

   P2Important issues not at the top of the work listImportant issues not at the top of the work list

   triaged-frameworkTriaged by Framework teamTriaged by Framework team

   on Dec 31, 2025
5. pedrisbel commented on Jan 14, 2026

   

   pedrisbel

   on Jan 14, 2026

   More actions

   Same issue but only in Android/IOS.

   👍React with 👍1Reacted by adonisRodxander
6. schindler-s commented on Feb 3, 2026

   

   schindler-s

   on Feb 3, 2026

   Last edited by schindler-s

   More actions

   go_router async pop issue – related reproduction

   We are seeing the same underlying problem in a slightly different (but likely related) setup, starting with go_router 16.0.0.

   In our case, we do not use onEnter callbacks, but we do use a ShellRoute combined with async redirect callbacks (returning Future.value(null)). From 15.1.3 → 16.0.0, context.pop() stopped working reliably.

   Observations

   The problem appears whenever multiple async lifecycle callbacks participate in the route resolution / pop chain, even if they are effectively no-ops.

   Affected async callbacks in our setup:

   • async top-level redirect
   • async ShellRoute.redirect
   • async onExit on the route being popped

   Observed behavior:

   • Removing async redirects (or making them synchronous) restores correct context.pop() behavior
   • Keeping redirects async, but reducing their number, changes whether the pop works or not
   • The issue reproduces on Web and Android, on both stable (3.38.9) and beta (3.41.0-0.2.pre)

   This aligns well with the hypothesis in the original issue that async callbacks combined with onExit lead to an invalid pop state, potentially completing the same route match future more than once (similar to the Bad state: Future already completed error).

   Even when async callbacks simply return Future.value(null) or Future.value(true), they are still sufficient to trigger the issue. This suggests the problem is not the async work itself, but the presence of async boundaries in the routing lifecycle.

   Additional observation

   In this ShellRoute-based example, the issue appears to be specific to go_router's pop handling:

   • context.pop() does not pop the route
   • Replacing it with Navigator.of(context).pop() works as expected and correctly pops the route
     Edit: If onExit itself awaits additional async work (such as showing a confirmation dialog), Navigator.of(context).pop() also stops working.
     Edit2: Popping the dialog with Navigator.of(context).pop() instead of context.pop() leads to expected behaviour again.

   This further suggests that the problem is related to go_router's internal imperative pop lifecycle rather than Flutter's Navigator itself.

   ShellRoute-based minimal reproduction

   Code Example

   import 'package:flutter/material.dart';
   import 'package:go_router/go_router.dart';
   
   void main() {
     runApp(const MinimalRouterApp());
   }
   
   class MinimalRouterApp extends StatelessWidget {
     const MinimalRouterApp({super.key});
   
     @override
     Widget build(BuildContext context) {
       return MaterialApp.router(
         title: 'Router Minimal App',
         routerConfig: GoRouter(
           debugLogDiagnostics: true,
           routerNeglect: true,
           redirectLimit: 10,
           redirect: (context, state) => Future.value(null),
           routes: [
             GoRoute(
               path: "/",
               pageBuilder: (context, state) => NoTransitionPage(child: Home()),
             ),
             ShellRoute(
               redirect: (context, state) => Future.value(null),
               pageBuilder: (context, state, child) =>
                   NoTransitionPage(child: child),
               routes: [
                 GoRoute(
                   path: "/main",
                   pageBuilder: (context, state) =>
                       NoTransitionPage(child: ShellMain()),
                   routes: [
                     GoRoute(
                       path: "sub",
                       pageBuilder: (context, state) =>
                           NoTransitionPage(child: ShellSub()),
                       onExit: (_, _) => Future.value(true),
                     ),
                   ],
                 ),
               ],
             ),
           ],
         ),
       );
     }
   }
   
   class Home extends StatelessWidget {
     const Home({super.key});
   
     @override
     Widget build(BuildContext context) {
       return Column(
         spacing: 12,
         mainAxisAlignment: MainAxisAlignment.center,
         children: [
           Text('Home', style: Theme.of(context).textTheme.headlineSmall),
           FilledButton(
             onPressed: () => context.go("/main"),
             child: const Text('Enter shell'),
           ),
         ],
       );
     }
   }
   
   class ShellMain extends StatelessWidget {
     const ShellMain({super.key});
   
     @override
     Widget build(BuildContext context) {
       return Column(
         spacing: 12,
         mainAxisAlignment: MainAxisAlignment.center,
         children: [
           Text('Shell Main', style: Theme.of(context).textTheme.headlineSmall),
           FilledButton(
             onPressed: () => context.go("/main/sub"),
             child: const Text('Go to sub route'),
           ),
         ],
       );
     }
   }
   
   class ShellSub extends StatelessWidget {
     const ShellSub({super.key});
   
     @override
     Widget build(BuildContext context) {
       return Column(
         spacing: 12,
         mainAxisAlignment: MainAxisAlignment.center,
         children: [
           Text('Shell Sub', style: Theme.of(context).textTheme.headlineSmall),
           OutlinedButton(onPressed: context.pop, child: const Text('Pop')),
         ],
       );
     }
   }
7. auto-submit

   added a commit that references this issue on Apr 14, 2026

   [go_router] Fix pop() restoring stale configuration when route has on…

   ...

   e8184df
8. creatorpiyush

   added a commit that references this issue on Jun 10, 2026

   [go_router] Fix pop() restoring stale configuration when route has on…

   ...

   781ea7f
9. Istiak-Ahmed78

   added a commit that references this issue on Jun 19, 2026

   [go_router] Fix pop() restoring stale configuration when route has on…

   ...

   a4dad13
10. Piinks

    added

    team-ecosystemOwned by Ecosystem teamOwned by Ecosystem team

    triaged-ecosystemTriaged by Ecosystem teamTriaged by Ecosystem team

    and removed

    team-frameworkOwned by Framework teamOwned by Framework team

    triaged-frameworkTriaged by Framework teamTriaged by Framework team

    on Aug 26, 2026