Repository navigation
Tests for dev/integration_tests/hook_user_defines don't run on CI (and currently fail) #180575
Description
As far as I can tell, the tests for dev/integration_tests/hook_user_defines were never added to a CI build and currently don't run.
They also fail when running them locally with flutter test:
Unhandled exception:
Invalid argument(s): User-define `magic_value` must be an integer, found: null.
#0 main.<anonymous closure> (file:///Users/goderbauer/dev/flutter/dev/integration_tests/hook_user_defines/hook/build.dart:13:7)
#1 build (package:hooks/src/api/build_and_link.dart:158:18)
#2 main (file:///Users/goderbauer/dev/flutter/dev/integration_tests/hook_user_defines/hook/build.dart:10:9)
#3 _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:312:33)
#4 _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:193:12)
This failure is probably due to resolution: workspace in the package's pubspec.yaml. The workspace pubspec does not define a value for the magic_value user define. Only the package-local pubspec does. We probably don't want random test user defines in the root pubspec. Maybe this packages has to be removed from the workspace?
Steps necessary to close this issue:
- Fix the tests of
dev/integration_tests/hook_user_defines - Make these tests run on CI somewhere (maybe as parts of the tools integration test shard?) so they don't break again.
Activity
goderbauer commentedon Jan 6, 2026
cc @dcharkes @bkonyi
goderbauer commentedon Jan 6, 2026
FWIW, the tests of
dev/integration_tests/link_hooksare also not running on CI. I am trying to fix that as part of #180507.dcharkes commentedon Jan 6, 2026
Yes, that would make sense. 👍 Unless there's a workspace for the integration tests as a group. (I would think integration test projects get copied to a temp directory, and then workspace resolution wouldn't work at all. How are the other integration tests run? Are they run in place?)
bkonyi commentedon Jan 6, 2026
They're run in place as they're part of the
_flutter_packagesworkspace at the root of the repository.Run hook_user_defines and link_hook integration tests on CI (#180622)
github-actions commentedon Jan 22, 2026
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.Run hook_user_defines and link_hook integration tests on CI (#180622)