You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Hide "this could be a framework bug" message when first stack frame is not framework #18412
We should hide the message saying this could be a framework bug if the first stack frame is not in the framework. In fact we should probably figure out which package is to blame and then explicitly name that.
@eduardkieser I don't think that is related to this issue: your stack trace starts within the framework, and doesn't have the "this could be a framework bug" message either.
I'm going to hide your comment (since it's irrelevant to this issue and long). If you're still having trouble, please ask on StackOverflow or file a new issue with a reduced test case.
Be a little bit less sensitive to dart changes in the stack. Since we wrote this logic, Dart added new frames/indirections into the assertion error throw.
Check to see if the next frame after the assert is non-framework code. If so, I'm going to say it's not our fault, but that the user is passing us bad values. If not, then we either need to add an assert higher up in the framework (e.g. a hypothetical widget that should assert a label value is not null before trying to create a Text widget with the label), or we need to fix some garbage in the framework (e.g. a hypothetical scroll view that messes up some sliver rules).
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
eduardkieser commentedon Jun 27, 2018
gspencergoog commentedon Jul 9, 2018
@eduardkieser I don't think that is related to this issue: your stack trace starts within the framework, and doesn't have the "this could be a framework bug" message either.
I'm going to hide your comment (since it's irrelevant to this issue and long). If you're still having trouble, please ask on StackOverflow or file a new issue with a reduced test case.
mit-mit commentedon Sep 20, 2018
Hi @gspencergoog did you get a chance to look at this? I just tried to re-repro #16260, and I still see it.
gspencergoog commentedon Sep 20, 2018
No, I haven't looked at this yet, but I'll look at it soon.
dnfield commentedon Jan 7, 2020
I'm going to look at this.
I'd like to amend the logic as follows:
Textwidget with the label), or we need to fix some garbage in the framework (e.g. a hypothetical scroll view that messes up some sliver rules).github-actions commentedon Aug 15, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.