Skip to content

examples/: missing await on FlutterDriver.close() in 3 test drivers #184315

Description

@randomizedcoder

Three example test drivers call driver.close() without await in tearDownAll(), silently dropping the Future<void>. This means the WebDriver connection is never reliably closed before the test process exits.

Affected files:

  • examples/hello_world/test_driver/smoke_web_engine_test.dart:28
  • examples/platform_channel/test_driver/button_tap_test.dart:17
  • examples/platform_channel_swift/test_driver/button_tap_test.dart:17

Root cause: PR #181513 systematically fixed unawaited FlutterDriver.close() callsites across packages/, dev/, and test/, but examples/ was not included in the sweep.

Fix: Add await to each driver.close() call. One-line change per file.

Activity

  1. added a commit that references this issue on Mar 29, 2026
    7310f40
  2. added
    in triagePresently being triaged by the triage team
    a: tests"flutter test", flutter_test, or one of our tests
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Mar 30, 2026
  3. mbcorona commented on Mar 30, 2026

    @mbcorona
    Member

    Hi @randomizedcoder.
    Thanks for the report and for taking the initiative to submit PR #184316 to fix it! Routing to team-framework to evaluate

  4. removed
    frameworkflutter/packages/flutter repository. See also f: labels.
    in triagePresently being triaged by the triage team
    on Mar 30, 2026
  5. added a commit that references this issue on Mar 31, 2026
  6. added a commit that references this issue on Apr 14, 2026
  7. github-actions commented on Apr 16, 2026

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. locked as resolved and limited conversation to collaborators on Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    a: tests"flutter test", flutter_test, or one of our testsd: examplesSample code and demosteam-frameworkOwned by Framework team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions