Skip to content

Rect SDFs have artifacts in "StrokedRectsRenderCorrectly" golden #184352

Closed
Closed
Rect SDFs have artifacts in "StrokedRectsRenderCorrectly" golden#184352
Assignees
b-luk
Labels
P2Important issues not at the top of the work liste: impellerImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Description

@gaaclarke
gaaclarke
opened on Mar 30, 2026

#183864 adds a stand in sdf for rects to get the foundations implemented. It has some goofy goldens though that should be fixed. I thought the artifacts were related to an inefficiency in the SDF math while we got all the plumbing setup, but the sdf is mathmatcially correct according to https://iquilezles.org/articles/distfunctions2d/

Image Image Image Image

Activity

  1. gaaclarke
    added
    e: impellerImpeller rendering backend issues and features requests
    team-engineOwned by Engine team
    on Mar 30, 2026
  2. b-luk
    self-assigned this
    on Mar 30, 2026
  3. github-merge-queue
    added a commit that references this issue on Apr 2, 2026

    Support different joins for stroked rects in uber_sdf, fix incorrect …

    d24ebdc
  4. jason-simmons
    added
    P2Important issues not at the top of the work list
    triaged-engineTriaged by Engine team
    on Apr 6, 2026
  5. github-merge-queue
    added a commit that references this issue on Apr 9, 2026

    UberSDFContent refactoring and handle stroke miter limit for stroked …

    47b5032
  6. mbcorona
    added 2 commits that reference this issue on Apr 15, 2026

    Support different joins for stroked rects in uber_sdf, fix incorrect …

    43fb07f

    UberSDFContent refactoring and handle stroke miter limit for stroked …

    3b7a815
  7. github-merge-queue
    added a commit that references this issue on Apr 18, 2026

    Change uber SDF to get pixel size (for AA) using euclidean distance r…

    4a26bed
  8. pull
    added a commit that references this issue on Apr 24, 2026

    Handle hairline strokes in UberSDF (flutter#184895)

    5bf85a6

  9. b-luk commented on Apr 24, 2026

    @b-luk
    b-luk
    on Apr 24, 2026
    Contributor

    After the fixes in #184395, #184603, #184984, and #184895 this golden looks very close to the non-SDF version.

  10. b-luk
    closed this as completedon Apr 24, 2026

  11. github-actions commented on May 8, 2026

    @github-actions
    github-actionsbot
    on May 8, 2026 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  12. github-actions
    locked as resolved and limited conversation to collaborators on May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work liste: impellerImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions